Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] PM / devfrq: Fix indentaion of devfreq_summary debugfs
 node
To:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     chanwoo@kernel.org, myungjoo.ham@samsung.com,
        kyungmin.park@samsung.com, stable@vger.kernel.org
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <f36a3413-74b7-74f6-e87d-b19d000cb3e0@samsung.com>
Date:   Mon, 27 Jul 2020 11:30:39 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20200713073112.6297-1-cw00.choi@samsung.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200713071942epcas1p14a9a1d2017e2e5005f7146f5bed09c82@epcas1p1.samsung.com>
        <20200713073112.6297-1-cw00.choi@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/13/20 4:31 PM, Chanwoo Choi wrote:
> The commit 66d0e797bf09 ("Revert "PM / devfreq: Modify the device name
> as devfreq(X) for sysfs"") roll back the device name from 'devfreqX'
> to device name explained in DT. After applied commit 66d0e797bf09,
> the indentation of devfreq_summary debugfs node was broken.
> 
> So, fix indentaion of devfreq_summary debugfs node as following:
> 
> For example on Exynos5422-based Odroid-XU3 board,
> $ cat /sys/kernel/debug/devfreq/devfreq_summary
> dev                            parent_dev                     governor        polling_ms  cur_freq_Hz  min_freq_Hz  max_freq_Hz
> ------------------------------ ------------------------------ --------------- ---------- ------------ ------------ ------------
> 10c20000.memory-controller     null                           simple_ondemand          0    413000000    165000000    825000000
> soc:bus_wcore                  null                           simple_ondemand         50     88700000     88700000    532000000
> soc:bus_noc                    soc:bus_wcore                  passive                  0     66600000     66600000    111000000
> soc:bus_fsys_apb               soc:bus_wcore                  passive                  0    111000000    111000000    222000000
> soc:bus_fsys                   soc:bus_wcore                  passive                  0     75000000     75000000    200000000
> soc:bus_fsys2                  soc:bus_wcore                  passive                  0     75000000     75000000    200000000
> soc:bus_mfc                    soc:bus_wcore                  passive                  0     83250000     83250000    333000000
> soc:bus_gen                    soc:bus_wcore                  passive                  0     88700000     88700000    266000000
> soc:bus_peri                   soc:bus_wcore                  passive                  0     66600000     66600000     66600000
> soc:bus_g2d                    soc:bus_wcore                  passive                  0     83250000     83250000    333000000
> soc:bus_g2d_acp                soc:bus_wcore                  passive                  0            0     66500000    266000000
> soc:bus_jpeg                   soc:bus_wcore                  passive                  0            0     75000000    300000000
> soc:bus_jpeg_apb               soc:bus_wcore                  passive                  0            0     83250000    166500000
> soc:bus_disp1_fimd             soc:bus_wcore                  passive                  0            0    120000000    200000000
> soc:bus_disp1                  soc:bus_wcore                  passive                  0            0    120000000    300000000
> soc:bus_gscl_scaler            soc:bus_wcore                  passive                  0            0    150000000    300000000
> soc:bus_mscl                   soc:bus_wcore                  passive                  0            0     84000000    666000000
> 
> Cc: stable@vger.kernel.org
> Fixes: commit 66d0e797bf09 ("Revert "PM / devfreq: Modify the device name as devfreq(X) for sysfs"")
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/devfreq/devfreq.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index ce82bdb5fa5c..2ff35ec1b53b 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1839,8 +1839,7 @@ static int devfreq_summary_show(struct seq_file *s, void *data)
>  	unsigned long cur_freq, min_freq, max_freq;
>  	unsigned int polling_ms;
>  
> -	seq_printf(s, "%-30s %-10s %-10s %-15s %10s %12s %12s %12s\n",
> -			"dev_name",
> +	seq_printf(s, "%-30s %-30s %-15s %10s %12s %12s %12s\n",
>  			"dev",
>  			"parent_dev",
>  			"governor",
> @@ -1848,10 +1847,9 @@ static int devfreq_summary_show(struct seq_file *s, void *data)
>  			"cur_freq_Hz",
>  			"min_freq_Hz",
>  			"max_freq_Hz");
> -	seq_printf(s, "%30s %10s %10s %15s %10s %12s %12s %12s\n",
> +	seq_printf(s, "%30s %30s %15s %10s %12s %12s %12s\n",
> +			"------------------------------",
>  			"------------------------------",
> -			"----------",
> -			"----------",
>  			"---------------",
>  			"----------",
>  			"------------",
> @@ -1880,8 +1878,7 @@ static int devfreq_summary_show(struct seq_file *s, void *data)
>  		mutex_unlock(&devfreq->lock);
>  
>  		seq_printf(s,
> -			"%-30s %-10s %-10s %-15s %10d %12ld %12ld %12ld\n",
> -			dev_name(devfreq->dev.parent),
> +			"%-30s %-30s %-15s %10d %12ld %12ld %12ld\n",
>  			dev_name(&devfreq->dev),
>  			p_devfreq ? dev_name(&p_devfreq->dev) : "null",
>  			devfreq->governor_name,
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics