Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp824124ybg; Sun, 26 Jul 2020 23:55:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyS/R/wVL7KlT+bnBWm51HH2FTPhm14Ift5kbjw5qKCiy6ya/3BmcbWA/GJBYHsmgCK0QE1 X-Received: by 2002:a05:6402:b57:: with SMTP id bx23mr19152280edb.304.1595832937513; Sun, 26 Jul 2020 23:55:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595832937; cv=none; d=google.com; s=arc-20160816; b=QoFlfwd7CXHaGcEC9q0VG32E65MnMgaup37y5T82KTW05zl+/ireaBSOFo10gDae5h A/7nBXpJIn6g3T/+vO6NAbuYsLvh0QTBzFOyezpp6pHLmHMVbUTjrFJQls3F8sPAq9VM PEbNDH6mSXXtbNz4eNAAfOrVPmtPGYeio7Gmnj6Y3E1SD3H/fT9L7PA5ftQfK9IqfX7V Y20kHTJe1OLgCFvQqfJZJcDXk221cEODpJqXSY25eWuDHgJCJIvNz2LOkyG1ngSP0WRU IN8/jaRh2b5re2loH+Mw8hkwNHL/k+/HzcP5DAfWRSzGQ35FvW8lP1FYRyWYcul2ro9D q8xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=QnDveecPJEREfCy9WTQwW7geYmhsS27FemAmE9uliww=; b=RsVJlKgcMlyeeuJfd/fiBjb3UZFO3Fe5EtwJmJZCCmEOSqDSIEk6Cvz4ff01mAlVs/ XqRTlCcNkTXhuEMRyTNPBVAfdhiKR5HBRAlz9MjVy3Yn1fOYXyUa6pQxeBO8w5xVgqi3 hO966KSzJM4JMPeaFURXdw4RgHjjalPJougygbUJh3Tzz5BwyYh4VJa5yPIuAVvqLPMM wmAunUMGqPxAoFQJn0HulQOOCL01Rk4xnTMvk9NihBq71ufUdJVhQz0btpYhQ8y1Uw6Y GzjCwMu2qAFP5g7J/G0o8oUyk7eEzM3OOvZBtSuBXeBwtwzM91ptHdOFWoafKKZbeE86 WQhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si5652899ejn.667.2020.07.26.23.55.15; Sun, 26 Jul 2020 23:55:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726213AbgG0Gwt (ORCPT + 99 others); Mon, 27 Jul 2020 02:52:49 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50994 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726122AbgG0Gws (ORCPT ); Mon, 27 Jul 2020 02:52:48 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jzwzu-0000b6-OZ; Mon, 27 Jul 2020 16:52:31 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Mon, 27 Jul 2020 16:52:30 +1000 Date: Mon, 27 Jul 2020 16:52:30 +1000 From: Herbert Xu To: Huang Guobin Cc: haren@us.ibm.com, ddstreet@ieee.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lib: Verify array index is correct before using it Message-ID: <20200727065230.GA25105@gondor.apana.org.au> References: <20200727065910.1628-1-huangguobin4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727065910.1628-1-huangguobin4@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 02:59:10AM -0400, Huang Guobin wrote: > This code reads from the array before verifying that "c" is a valid > index. Move test array offset code before use to fix it. > > Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") > Signed-off-by: Huang Guobin > --- > lib/842/842_compress.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Please post this to linux-crypto@vger.kernel.org. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt