Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp838983ybg; Mon, 27 Jul 2020 00:27:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOR7VyByydCZTV9TOl7ET4UOYT8fm/KswummUaDEQN+ZAPCfBXW3ji3c4R1F8AxcqAF20n X-Received: by 2002:a05:6402:947:: with SMTP id h7mr20330332edz.213.1595834852867; Mon, 27 Jul 2020 00:27:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595834852; cv=none; d=google.com; s=arc-20160816; b=M1XoX95kKS5pxEh44H7LLZfy7qhDTRgYHvWhw6NJ82hVu3lnqFNoWXbtTh7240Wehk kJ7BPcsXgzbbjPCROFkTvRjd8Z5ty4J9t8NGRwqWq9oOSKNpzZOLBGuC+LZ4hiycMwJm yqMm8MTCX93wQB4itc244em8JixssjQFcGGYqXM7EfuY6BYFKRO4frgai0DuQiaTzFlt VcOYcnURXP0xqmx0OrGdW4Ao7r8rUenhozrVaSNOSiDfJQ0QljHmjzJ/FH/2z1Yvz9Vf bTn7L1FkfCaq2ks7IGjk56r/aJ9OArlS89ZFysiF2C7NIchLCUwonfZZxTjpWUq+Ss+6 Bzjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:references :in-reply-to:cc:to:from; bh=iiqbYjfrRFMHZbqWBFMYma6y9XoAuj3D280nvTcCkgI=; b=fzn7Yggk/r/BmpP1Atyz6B48+VXDT0vBqISH4Kqz+94Kajs9JAukwdEP6mkUWpTRE2 IUY87J7GtvOJFxCzbCrclThHKZHdYEpO1vFR51FTHsGG3+x6ajGLAAWSBQ3UVyKqfTYe una1+cex0d+8qjo/lL588jQwSmfuxxA1iH7zyDlzvBWltNRKBqjb6fyE+ukqXVvVFjE4 +MQs95hP0wYedS9i/GzvDMgyYsPEBhMCMS7+ahn90Yy/YYiWRQT2kkdiri/wZ4IaLA6i 5r0gLcf7XPMLrwD1Bneba5MXTsA1+4zOlFp6LeoBPEQeeUzsA2C2vt1sJpGwMboka5nP sJkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z24si3487534ejx.483.2020.07.27.00.27.11; Mon, 27 Jul 2020 00:27:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbgG0H0x (ORCPT + 99 others); Mon, 27 Jul 2020 03:26:53 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:34177 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbgG0H0u (ORCPT ); Mon, 27 Jul 2020 03:26:50 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 4BFWZw3Xqrz9sTV; Mon, 27 Jul 2020 17:26:48 +1000 (AEST) From: Michael Ellerman To: Finn Thain , Benjamin Herrenschmidt Cc: Mark Cave-Ayland , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Joshua Thompson , linuxppc-dev@lists.ozlabs.org, Laurent Vivier , linux-kernel@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH 0/9] Macintosh II ADB driver fixes Message-Id: <159583478319.602200.6930356633424802467.b4-ty@ellerman.id.au> Date: Mon, 27 Jul 2020 17:26:48 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 Jun 2020 14:23:12 +1000, Finn Thain wrote: > Various issues with the via-macii driver have become apparent over the > years. Some examples: > > - A Talk command response can be lost. This can result in phantom devices > being probed or an incorrect device handler ID being retrieved. > > - A reply packet containing a null byte can get truncated. Such packets > are sometimes generated by ADB keyboards. > > [...] Applied to powerpc/next. [1/9] macintosh/via-macii: Access autopoll_devs when inside lock https://git.kernel.org/powerpc/c/59ea38f6b3af5636edf541768a1ed721eeaca99e [2/9] macintosh/via-macii: Poll the device most likely to respond https://git.kernel.org/powerpc/c/f93bfeb55255bddaa16597e187a99ae6131b964a [3/9] macintosh/via-macii: Handle /CTLR_IRQ signal correctly https://git.kernel.org/powerpc/c/b4d76c28eca369b8105fe3a0a9f396e3fbcd0dd5 [4/9] macintosh/via-macii: Remove read_done state https://git.kernel.org/powerpc/c/b16b67689baa01a5616b651356df7ad3e47a8763 [5/9] macintosh/via-macii: Handle poll replies correctly https://git.kernel.org/powerpc/c/624cf5b538b507293ec761797bd8ce0702fefe64 [6/9] macintosh/via-macii: Use bool type for reading_reply variable https://git.kernel.org/powerpc/c/f87a162572c9f7c839a207c7de6c73ffe54a777c [7/9] macintosh/via-macii: Use unsigned type for autopoll_devs variable https://git.kernel.org/powerpc/c/5c0c15a1953a7de2878d7e6f5711fd3322b11faa [8/9] macintosh/via-macii: Use the stack for reset request storage https://git.kernel.org/powerpc/c/046ace8256489f32740da07de55a913ca09ce5cf [9/9] macintosh/via-macii: Clarify definition of macii_init() https://git.kernel.org/powerpc/c/3327e58a04501e06aa531cdb4044aab214a6254a cheers