Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751535AbWEKE5u (ORCPT ); Thu, 11 May 2006 00:57:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751536AbWEKE5u (ORCPT ); Thu, 11 May 2006 00:57:50 -0400 Received: from smtp.osdl.org ([65.172.181.4]:40325 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751524AbWEKE5t (ORCPT ); Thu, 11 May 2006 00:57:49 -0400 Date: Wed, 10 May 2006 21:48:41 -0700 From: Andrew Morton To: Latchesar Ionkov Cc: linux-kernel@vger.kernel.org, Eric Van Hensbergen Subject: Re: [PATCH] v9fs: signal handling fixes Message-Id: <20060510214841.17553cfe.akpm@osdl.org> In-Reply-To: <20060506191726.GB8063@ionkov.net> References: <20060506191726.GB8063@ionkov.net> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 17 Latchesar Ionkov wrote: > > + clear_thread_flag(TIF_SIGPENDING); It is unusual and arguably inappropriate for a filesystem to be playing with thread flags in this manner. There are no comments in there explaining why this is happening (there should be: unusual and surprising things should always be commented, no?) so I must ask on a mailing list. What's going on in there? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/