Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp849604ybg; Mon, 27 Jul 2020 00:52:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLXH72+jXwFchfnMUZRbHZYU/S7V+ecqqawbO1sMu+PPCoL71tG10/jwl3a6xK3OdMZfnv X-Received: by 2002:a17:906:1747:: with SMTP id d7mr19688509eje.39.1595836322901; Mon, 27 Jul 2020 00:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595836322; cv=none; d=google.com; s=arc-20160816; b=KU9O2U/djswO/HJVxJ3jQYkyuTLTKTGL4l487C42ap35wpL45pSPmqm6VWxiqpCfvm 71A0NKHCs5kaydc+o5+7TAyy27xt0KnR9rfPha84S24KtbpnzBd2EQ1VTphtr94G9+bz 7DbnbE/VPc2/FqG/9BV0W1AVvxB2kdUFQ0g5I6rObF5ePViRoZBqwE8E8vvaLtAkE/9p Ty5peFcxQNBCfJ/3YuoUx6Wy5sZFj9VN8tCEU81KuYC69clH17zIgKS6722R9ijTv9G2 azru5/Bzz2wBlU3rA1Q9d3bgaISua7v5/wOeNt0vu4+/OPYHvozrEnAhu4xWyq6oVTNy 5XIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HvRchyhkxeOLvzDuOrbaCYZ/zyb156MiLRE1ABCH84I=; b=Ke+qsnr81o6luHJvXPFHea4VAYVEik5ppcJn4JJZP44xugvJOA79/vZCmx9xapRkhi RqIO070Lmkp0VhfAascRjOCKumZEH3ttCOsmqeT76gShFPbVgNSl2ttmfhKXl55BekeD McjaLCKi67jbziRlC0v72HsDjNSS2xrwp3gblCjSOPHwj+UhUuKo/3ylM4yTDnPQC0tt tjXuGguCeJm4HMJwIRx3bwwtJNQFu8noh41x2Sg7rBkGbRNNbwoVjiN/MTKip5F41v80 UeV4K8U7vMSUxWkhR90gnVhVIr3d0pjAIr2eHMwL4YPdXRWE2mfFm+TFJovJaTbwA2tq zmGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KHuKlq97; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h28si6151549edj.267.2020.07.27.00.51.41; Mon, 27 Jul 2020 00:52:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KHuKlq97; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgG0Hu5 (ORCPT + 99 others); Mon, 27 Jul 2020 03:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbgG0Hu5 (ORCPT ); Mon, 27 Jul 2020 03:50:57 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 421DEC0619D2; Mon, 27 Jul 2020 00:50:57 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id z5so8985473pgb.6; Mon, 27 Jul 2020 00:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HvRchyhkxeOLvzDuOrbaCYZ/zyb156MiLRE1ABCH84I=; b=KHuKlq97lOmpgvmfdymhvpN8uf/hANCv3kkGu6QGEqkIdNfGIKZoOZhPHipHkLubxz POPDaIvlCDmqdt9EHt7kMEd2b/8zf6vzgQHOUoqBub+XyOdPIzUhYy/M7DPe1oBeuxHm VT6qGOMZw880nUoP71XlImKhZHXsHRa6k7ISxETfFyQWt4qsYJEqtGdsxmMoiFbRPzW7 xIdi8aQIpCR4QQU98/NyNdI8wHvkq5pL1AZmHs3ozQH0nJRU8LdmLjMxR2dn+3BAkL+w wVzyC0kgNbBOgIa6RjciRV692+rSYDnkvWWtH0diAUZ0nlE8RHT718PeeBTdn4lFfUpR IFaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HvRchyhkxeOLvzDuOrbaCYZ/zyb156MiLRE1ABCH84I=; b=HCleAqbcx+s9vj2bLP8jhzp+X46HhVkMUSek6zuN0/EeGaMN3feNdEn8sTvi5WeJ83 NA/Zi3197LovCvVwoOx5N3vkj9Aov1IwjFrp4O2HiSemiDfjtvWfApcebwmhQ1T4ySLa gvdKLs1PvMraT6+8nklmPH1wWk5ncLBFbNtoGhE2KDBYdz+0YlAcCqYBx3bQaUz3Qh8+ imghdUJ79CZ6rehvlgTAB6QReeH+oRwKeHjHXSWlWWnO3H85GwgWjUM9KxWvgcvROHRL GrWmNusLa7MMPWAH1B9Uts9rlZOKCMa/YAHbaYqdUB0y9rzu9r4Z5vA9dN5KDAs7dqE+ sQYQ== X-Gm-Message-State: AOAM530tDAsn5x94XOZAUcFIHHriepA3vTfPXMMyJ6aBgOQIAubxDwrl gryum4sAjdSdAl4F+UdiO5alzG64fcGlvdcuoP4= X-Received: by 2002:a63:924b:: with SMTP id s11mr18169222pgn.74.1595836256878; Mon, 27 Jul 2020 00:50:56 -0700 (PDT) MIME-Version: 1.0 References: <20200607162350.21297-1-mani@kernel.org> <20200607162350.21297-3-mani@kernel.org> <20200701130206.GD3334@localhost> <20200726155223.GB12036@Mani-XPS-13-9360> <20200727044610.GC12036@Mani-XPS-13-9360> In-Reply-To: <20200727044610.GC12036@Mani-XPS-13-9360> From: Andy Shevchenko Date: Mon, 27 Jul 2020 10:50:39 +0300 Message-ID: Subject: Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support To: Manivannan Sadhasivam Cc: Johan Hovold , Greg Kroah-Hartman , USB , Linux Kernel Mailing List , patong.mxl@gmail.com, Linus Walleij , Mauro Carvalho Chehab , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 7:46 AM Manivannan Sadhasivam wrote: > On Sun, Jul 26, 2020 at 07:34:54PM +0300, Andy Shevchenko wrote: > > On Sun, Jul 26, 2020 at 6:53 PM Manivannan Sadhasivam wrote: ... > > I'm wondering if you may use mctrl_gpio_*() API instead. > > How? mctrl_gpio APIs are a wrapper for accessing modem control gpio pins but > here we are not accessing the pins but rather exposing the pins as a gpiochip. I see. Thanks for the explanation. > Am I missing something? -- With Best Regards, Andy Shevchenko