Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Jul 2020 14:37:11 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Rajesh Gumasta <rgumasta@nvidia.com>
Cc:     ldewangan@nvidia.com, jonathanh@nvidia.com,
        dan.j.williams@intel.com, thierry.reding@gmail.com,
        p.zabel@pengutronix.de, dmaengine@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        kyarlagadda@nvidia.com, Pavan Kunapuli <pkunapuli@nvidia.com>
Subject: Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver
Message-ID: <20200727090711.GN12965@vkoul-mobl>
References: <1595226856-19241-1-git-send-email-rgumasta@nvidia.com>
 <1595226856-19241-3-git-send-email-rgumasta@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1595226856-19241-3-git-send-email-rgumasta@nvidia.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20-07-20, 12:04, Rajesh Gumasta wrote:
> v4 changes: Removed pending dma desc list and other unused
> data structures
> 
> v3 changes: Removed free list for dma_desc and sg

This is v1 patch and we have v3/v4 stuff! Anyway this can go after the
marker succeeding sob line or cover!

> 
> Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver
> supports dma transfers between memory to memory, IO to memory and
> memory to IO.

This is dmaengine subsystem, so please tag to appropriately

> +/* MMIO sequence register */
> +#define TEGRA_GPCDMA_CHAN_MMIOSEQ		0x01c
> +#define TEGRA_GPCDMA_MMIOSEQ_DBL_BUF		BIT(31)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_8	(0 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_16	(1 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_32	(2 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_64	(3 << 28)
> +#define TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_128	(4 << 28)

GENMASK for these please

> +static int tegra_dma_slave_config(struct dma_chan *dc,
> +		struct dma_slave_config *sconfig)
> +{
> +	struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
> +
> +	if (!list_empty(&tdc->pending_sg_req)) {
> +		dev_err(tdc2dev(tdc), "Configuration not allowed\n");

why is that?

Also run checkpatch --strict on this before sending.

Thanks
-- 
~Vinod