Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp892667ybg; Mon, 27 Jul 2020 02:24:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKbfLud9dPws4eS9l2zZ8SSifzYPxWA67PoW1ifzZ1nCyxcrXzGiMqXtznaJW8YG+Xp3WN X-Received: by 2002:aa7:d989:: with SMTP id u9mr20334680eds.85.1595841868218; Mon, 27 Jul 2020 02:24:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595841868; cv=none; d=google.com; s=arc-20160816; b=xX/VIJyPqpUKhC+1MmOLg6+UGWVEXDcCRhtCemS1bikYD0bLDaU9Xr99gYC/z1Mtez jQ9HwyfOXazBM6qzKGcFBm0DHH+ARGPlIPDoYQeGlX9vtsaEI3JwZKQNAyEr5GkWgUI+ E373l0XEzfRNZFz0y6t7zW/qTYd1CNeTjD5e5Id6BNHTJ0QxUb+wiTPKgo5FVyT99Q4y MaQZA+4YtrmvfUJqk5ozBp5hSKQFmUawcgJsY5Cw7rZshT5N3COU+6cOPhhZC0AJF0r/ Q+rxLwgP2dwRzyDKC5SPPUOTAjKF7akfdcKbunrtlIrdIvNuoVzxem6kV6AYolYOmCd+ wVrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=bjneXtfoNCI6j1U3UV3+86uvetDKTRNsga2gRb+oNJ0=; b=hWOzDnGiauufj4lrsvIuBEXi0eEHNrJkhheb3iddnRErbScd7SvMGPY4EaOTxXCuIC 1g0Z72ILupUGlgMVF8sU6ljlJX43zveBk8A0c9gUAuT9lH/bLkPQFAfLLuiK1OW7k3zC V/R9htH08xxEvOQ2uAsb2ZELx7vtoavUNUlIpDf37n80zZMZZDAW9Dp5CrVMyoD2gvx4 7Kuy9PdF/VzyWePaKsiKSUlhiJnQQq2vBq0a+huMHct0tMvvpJE2miCxro0TVu0BaLFi NxAxTDviKHLQsHP/e+0DU7YbNLFWgxU7mBic76swo9uaEJbqJILoViYBux9qiW6MFt2h UWFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si5271924ejo.392.2020.07.27.02.24.05; Mon, 27 Jul 2020 02:24:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728027AbgG0JXH (ORCPT + 99 others); Mon, 27 Jul 2020 05:23:07 -0400 Received: from mga09.intel.com ([134.134.136.24]:46540 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727847AbgG0JXG (ORCPT ); Mon, 27 Jul 2020 05:23:06 -0400 IronPort-SDR: YFk8xEe34AGUJNu/CbTER0QAjfP0tdP4c7kl1yN156BHeTPGFopnr59IFtqdkcQHQ+E6LZZJE2 tJKGjQIMj1Qw== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="152237658" X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="152237658" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2020 02:23:06 -0700 IronPort-SDR: EADzguSBCVBvXtLtLQokGGRkJcM++W6KAf8Gdrx27SurASfO4wAJymTTIC3hqoX1pc3cFo9Bry S6/mw6GcKLog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="303393843" Received: from pg-nxl3.altera.com ([10.142.129.93]) by orsmga002.jf.intel.com with ESMTP; 27 Jul 2020 02:23:03 -0700 From: "Ooi, Joyce" To: Thor Thayer , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Joyce Ooi , Tan Ley Foon , See Chin Liang , Dinh Nguyen , Dalon Westergreen Subject: [PATCH v5 03/10] net: eth: altera: fix altera_dmaops declaration Date: Mon, 27 Jul 2020 17:21:50 +0800 Message-Id: <20200727092157.115937-4-joyce.ooi@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20200727092157.115937-1-joyce.ooi@intel.com> References: <20200727092157.115937-1-joyce.ooi@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi Reviewed-by: Thor Thayer --- v2: no change v3: no change v4: no change v5: no change --- drivers/net/ethernet/altera/altera_tse.h | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h index f17acfb579a0..7d0c98fc103e 100644 --- a/drivers/net/ethernet/altera/altera_tse.h +++ b/drivers/net/ethernet/altera/altera_tse.h @@ -385,20 +385,22 @@ struct altera_tse_private; struct altera_dmaops { int altera_dtype; int dmamask; - void (*reset_dma)(struct altera_tse_private *); - void (*enable_txirq)(struct altera_tse_private *); - void (*enable_rxirq)(struct altera_tse_private *); - void (*disable_txirq)(struct altera_tse_private *); - void (*disable_rxirq)(struct altera_tse_private *); - void (*clear_txirq)(struct altera_tse_private *); - void (*clear_rxirq)(struct altera_tse_private *); - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *); - u32 (*tx_completions)(struct altera_tse_private *); - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *); - u32 (*get_rx_status)(struct altera_tse_private *); - int (*init_dma)(struct altera_tse_private *); - void (*uninit_dma)(struct altera_tse_private *); - void (*start_rxdma)(struct altera_tse_private *); + void (*reset_dma)(struct altera_tse_private *priv); + void (*enable_txirq)(struct altera_tse_private *priv); + void (*enable_rxirq)(struct altera_tse_private *priv); + void (*disable_txirq)(struct altera_tse_private *priv); + void (*disable_rxirq)(struct altera_tse_private *priv); + void (*clear_txirq)(struct altera_tse_private *priv); + void (*clear_rxirq)(struct altera_tse_private *priv); + int (*tx_buffer)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*tx_completions)(struct altera_tse_private *priv); + void (*add_rx_desc)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*get_rx_status)(struct altera_tse_private *priv); + int (*init_dma)(struct altera_tse_private *priv); + void (*uninit_dma)(struct altera_tse_private *priv); + void (*start_rxdma)(struct altera_tse_private *priv); }; /* This structure is private to each device. -- 2.13.0