Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp892880ybg; Mon, 27 Jul 2020 02:24:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySYOfm1gxW4FYLBf282pbbOH0BoSxYEiJlOv9YsxwJ/OJoq056Bd6TglxIj6MtLPzpMRyp X-Received: by 2002:a17:906:3acd:: with SMTP id z13mr20462455ejd.69.1595841895449; Mon, 27 Jul 2020 02:24:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595841895; cv=none; d=google.com; s=arc-20160816; b=lx9dDlKDoWHrfSucwKThfbKMEnf1FaBXI3O/ZjM27JIm3ImmANYefllsrpuOxCb3pM 90M3RGj5aXxf/rGCA+hV5I9xlT2Qyj0sr/NlVGUpLbdHq7ElHrWllH6ntosaPPOmCe3E 3LIK9LW7p/yQQmA+smH0lW1QLmft+dBVJfUiqiWUrIqpbUKMhDEgm05/idEKmJERoXi8 4OJFdT/oAWWVFzKfQKxd4tXmSGu46Tmyvo3k+wJQuyqx3zGX4VocRYKKS/bX8+wuvecT eoFUqzklzWyaEbyayDvQDzuuVG6b8jEj/F99BFdxOmd8pnUHi53CCdIWmvFCwYr79m05 h83w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=4pvJOFts1Wvnn1jU4UvlOXni1xEgYveJxkUMqOSn7y0=; b=Vy0UfC66vofYkvbuyvDH83oC7fvNSZ5UQ8DPvcNFAgEi2ts1uLINAIkOsLs8ymI37l Xj0UGJ4iWERzXxmvQagh9glzM/ubT1dwXQUg+kMEtfoRkM88f20WFWJTBfQWDjRb0ZRi 1dwZlUdjCk9Sji70CQ7HQmeC86uFwTlevWgP8wRqivbEgqTGO+r9e2WxmbxloPJBCavF ADLAt4d0a6oWkjBYQ6ieDJch/8mZ0aiwdxvl+9ijipMfoJFyYw/qhAelKUQTrmjIiucX lB6ASjxgH0qIQe/oKwRaMdvbImdW1gWDRwUC1xl+ityytjVUURhEEd7fVR1pIySNVznN JjsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha20si4886921ejb.683.2020.07.27.02.24.33; Mon, 27 Jul 2020 02:24:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbgG0JXz (ORCPT + 99 others); Mon, 27 Jul 2020 05:23:55 -0400 Received: from mga04.intel.com ([192.55.52.120]:61549 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbgG0JXz (ORCPT ); Mon, 27 Jul 2020 05:23:55 -0400 IronPort-SDR: rZbIDD6voblG7o8JvDtE7GUGQr/pysa14J+X9acICLhQlunQJggj2TCMyUa1lOh4xodXWnP3S0 HRDLZHnUMv+A== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="148454931" X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="148454931" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2020 02:23:55 -0700 IronPort-SDR: r5OdIxDpmb0lPUEmTgiF/kI2TG2cBA5/g1Zs4l30xQfG71HKjZEkS2K5jE3OhupmCUptW/3msn 8lW6r9y+EfZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="303393947" Received: from pg-nxl3.altera.com ([10.142.129.93]) by orsmga002.jf.intel.com with ESMTP; 27 Jul 2020 02:23:51 -0700 From: "Ooi, Joyce" To: Thor Thayer , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Joyce Ooi , Tan Ley Foon , See Chin Liang , Dinh Nguyen Subject: [PATCH v5 06/10] net: eth: altera: Add missing identifier names to function declarations Date: Mon, 27 Jul 2020 17:21:53 +0800 Message-Id: <20200727092157.115937-7-joyce.ooi@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20200727092157.115937-1-joyce.ooi@intel.com> References: <20200727092157.115937-1-joyce.ooi@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dalon Westergreen The sgdma and msgdma header files included function declarations without identifier names for pointers. Add appropriate identifier names. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi Reviewed-by: Thor Thayer --- v2: this patch is added in patch version 2 v3: no change v4: no change v5: no change --- drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++++++------------- drivers/net/ethernet/altera/altera_sgdma.h | 32 +++++++++++++++-------------- 2 files changed, 33 insertions(+), 29 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_msgdma.h b/drivers/net/ethernet/altera/altera_msgdma.h index 9813fbfff4d3..23f5b2a13898 100644 --- a/drivers/net/ethernet/altera/altera_msgdma.h +++ b/drivers/net/ethernet/altera/altera_msgdma.h @@ -6,19 +6,21 @@ #ifndef __ALTERA_MSGDMA_H__ #define __ALTERA_MSGDMA_H__ -void msgdma_reset(struct altera_tse_private *); -void msgdma_enable_txirq(struct altera_tse_private *); -void msgdma_enable_rxirq(struct altera_tse_private *); -void msgdma_disable_rxirq(struct altera_tse_private *); -void msgdma_disable_txirq(struct altera_tse_private *); -void msgdma_clear_rxirq(struct altera_tse_private *); -void msgdma_clear_txirq(struct altera_tse_private *); -u32 msgdma_tx_completions(struct altera_tse_private *); -void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *); -int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *); -u32 msgdma_rx_status(struct altera_tse_private *); -int msgdma_initialize(struct altera_tse_private *); -void msgdma_uninitialize(struct altera_tse_private *); -void msgdma_start_rxdma(struct altera_tse_private *); +void msgdma_reset(struct altera_tse_private *priv); +void msgdma_enable_txirq(struct altera_tse_private *priv); +void msgdma_enable_rxirq(struct altera_tse_private *priv); +void msgdma_disable_rxirq(struct altera_tse_private *priv); +void msgdma_disable_txirq(struct altera_tse_private *priv); +void msgdma_clear_rxirq(struct altera_tse_private *priv); +void msgdma_clear_txirq(struct altera_tse_private *priv); +u32 msgdma_tx_completions(struct altera_tse_private *priv); +void msgdma_add_rx_desc(struct altera_tse_private *priv, + struct tse_buffer *buffer); +int msgdma_tx_buffer(struct altera_tse_private *priv, + struct tse_buffer *buffer); +u32 msgdma_rx_status(struct altera_tse_private *priv); +int msgdma_initialize(struct altera_tse_private *priv); +void msgdma_uninitialize(struct altera_tse_private *priv); +void msgdma_start_rxdma(struct altera_tse_private *priv); #endif /* __ALTERA_MSGDMA_H__ */ diff --git a/drivers/net/ethernet/altera/altera_sgdma.h b/drivers/net/ethernet/altera/altera_sgdma.h index 08afe1c9994f..3fb201417820 100644 --- a/drivers/net/ethernet/altera/altera_sgdma.h +++ b/drivers/net/ethernet/altera/altera_sgdma.h @@ -6,20 +6,22 @@ #ifndef __ALTERA_SGDMA_H__ #define __ALTERA_SGDMA_H__ -void sgdma_reset(struct altera_tse_private *); -void sgdma_enable_txirq(struct altera_tse_private *); -void sgdma_enable_rxirq(struct altera_tse_private *); -void sgdma_disable_rxirq(struct altera_tse_private *); -void sgdma_disable_txirq(struct altera_tse_private *); -void sgdma_clear_rxirq(struct altera_tse_private *); -void sgdma_clear_txirq(struct altera_tse_private *); -int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *); -u32 sgdma_tx_completions(struct altera_tse_private *); -void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *); -void sgdma_status(struct altera_tse_private *); -u32 sgdma_rx_status(struct altera_tse_private *); -int sgdma_initialize(struct altera_tse_private *); -void sgdma_uninitialize(struct altera_tse_private *); -void sgdma_start_rxdma(struct altera_tse_private *); +void sgdma_reset(struct altera_tse_private *priv); +void sgdma_enable_txirq(struct altera_tse_private *priv); +void sgdma_enable_rxirq(struct altera_tse_private *priv); +void sgdma_disable_rxirq(struct altera_tse_private *priv); +void sgdma_disable_txirq(struct altera_tse_private *priv); +void sgdma_clear_rxirq(struct altera_tse_private *priv); +void sgdma_clear_txirq(struct altera_tse_private *priv); +int sgdma_tx_buffer(struct altera_tse_private *priv, + struct tse_buffer *buffer); +u32 sgdma_tx_completions(struct altera_tse_private *priv); +void sgdma_add_rx_desc(struct altera_tse_private *priv, + struct tse_buffer *buffer); +void sgdma_status(struct altera_tse_private *priv); +u32 sgdma_rx_status(struct altera_tse_private *priv); +int sgdma_initialize(struct altera_tse_private *priv); +void sgdma_uninitialize(struct altera_tse_private *priv); +void sgdma_start_rxdma(struct altera_tse_private *priv); #endif /* __ALTERA_SGDMA_H__ */ -- 2.13.0