Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp905667ybg; Mon, 27 Jul 2020 02:51:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd7bbWGDDKF2z7aG4UK65+p8mOysg6dupD4nezeBcIGWzXnDZ8JmtnBD3Q95Se7nJWyejl X-Received: by 2002:a05:6402:17ab:: with SMTP id j11mr3699025edy.28.1595843469324; Mon, 27 Jul 2020 02:51:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595843469; cv=none; d=google.com; s=arc-20160816; b=VouFVby96x1izuUzeB6JTiHD7WUx7yqYZ39XFVXQQEK5JJmLnS65GwjxSFUraNweX2 72efflxAY6TQSix+YR3b5PQOyWsXTv3SM7M99jlQ/7XGY8wL73xeqkIKbSjPiAWwxRmz SOT/nJBuda50tzJiuZkZ9xweCp7BS+XAu9lRiggOSxC1WnlZDSd4pdV3KHYEJ6kH23G4 WiiFZYOGBIxxRInJ2othIzD9KiOAN/FnJqq3h1jWTFmzPmmz1gxeYYuGM787fmGC+JVo dzHwmZO5zjz4T4nfyPcukNqbfhHcKgX2zodIjspaCulMvRWqfF9l+25PeSCcK9kSaY6F z4mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dmarc-filter:dkim-signature; bh=Kbjy0E1cyBAH7os5xRP4ZFWN/pUN1FsBi0P64wEC5LI=; b=LpMTNBOKmiRFPY6Rd0l9bH86u8jQvDpz3dmJuZuKffjHv3aBylogVNypsOEHKwHMZB qyWqIDZAKFUSNa1mOB9QknvJCqHtcWgWYnpuE9Gqlc7lSXcjoVwrWMYxJugdhz2ACF6Y tbKKwBEbsD9rTmCzWyHToHNFPIs6V6hR7GQbJhqSRIPyQIPMXtuimBK2vdsBclisOOZI TtV3/YH8a8w2Vv5PmdDPrQQXhWy3d8tzr7UZ07K1mtXEAvyggHpTHTC4t0dX+BcZd7BS wUqjuYWClJen/S8s6H0W98BE9RG/q9vWPkGt/I6Oo2chU/jLjr8J9XIR+HNF4HjLddM1 E5Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=dzevA4ip; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d9si5192194edh.442.2020.07.27.02.50.47; Mon, 27 Jul 2020 02:51:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=dzevA4ip; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726781AbgG0JuQ (ORCPT + 99 others); Mon, 27 Jul 2020 05:50:16 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:53072 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgG0JuP (ORCPT ); Mon, 27 Jul 2020 05:50:15 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595843414; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: To: Subject: Sender; bh=Kbjy0E1cyBAH7os5xRP4ZFWN/pUN1FsBi0P64wEC5LI=; b=dzevA4ipkOY4Zy580L8euz2e+uBHllOynb+CotBJRCF/P/7EN/vMxrAD+X94GeRm3j2cU0k8 S2B5wE76Q4Qvkb/hk2jq4PuI/U4rfe3+KGiy9KeHygMYp1t1E0p+X00YhoSVoP674LMMp/Kd cb9KSB8WMdFMkuNmKwdYpMIjuj4= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5f1ea355634c4259e31b7b8b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 27 Jul 2020 09:50:13 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E1D83C433A0; Mon, 27 Jul 2020 09:50:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=ALL_TRUSTED,NICE_REPLY_A, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.0.129] (unknown [183.83.142.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rohitkr) by smtp.codeaurora.org (Postfix) with ESMTPSA id 119ACC433C9; Mon, 27 Jul 2020 09:50:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 119ACC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=rohitkr@codeaurora.org Subject: Re: [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant To: Srinivas Kandagatla , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1595413915-17867-1-git-send-email-rohitkr@codeaurora.org> From: Rohit Kumar Message-ID: Date: Mon, 27 Jul 2020 15:20:05 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote: > > > On 22/07/2020 11:31, Rohit kumar wrote: >> This patch chain add audio support for SC7180 soc by doing the required >> modification in existing common lpass-cpu/lpass-platform driver. >> This also fixes some concurrency issue. >> >> Changes since v3: >>     - Fixed yaml documentation comments and make dt_binding_check >> issues. >>     - Moved general fixes out of sc7180 specific patches as suggested >> by Srinivas. >>     - Update clock-names to make it same as existing platforms. >> >> Ajit Pandey (4): >>    ASoC: qcom: Add common array to initialize soc based core clocks >>    ASoC: qcom: lpass-platform: Replace card->dev with component->dev >>    include: dt-bindings: sound: Add sc7180-lpass bindings header >>    ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio >> >> Rohit kumar (8): >>    ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function >>    ASoC: qcom: lpass-platform: fix memory leak >>    ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers >>    ASoC: qcom: lpass-cpu: fix concurrency issue >>    dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node >>    ASoC: qcom: lpass-cpu: Use platform_get_resource >>    ASoC: qcom: lpass-platform: Use platform_get_irq >>    dt-bindings: sound: lpass-cpu: Move to yaml format > > Thanks Srini for review and testing. Mark, I am planning to repost patch07 onwards to address comments by Rob as there are no comments till patch06 and they are just fixes. > Tested this on Dragon Board 410c! > > Tested-by: Srinivas Kandagatla > > --srini >> >>   .../devicetree/bindings/sound/qcom,lpass-cpu.txt   |  79 -------- >>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml  | 185 >> ++++++++++++++++++ >>   include/dt-bindings/sound/sc7180-lpass.h           |  10 + >>   sound/soc/qcom/Kconfig                             |   5 + >>   sound/soc/qcom/Makefile                            |   2 + >>   sound/soc/qcom/lpass-apq8016.c                     |  86 ++++++-- >>   sound/soc/qcom/lpass-cpu.c                         | 204 >> ++++++++++--------- >>   sound/soc/qcom/lpass-ipq806x.c                     |  67 +++++++ >>   sound/soc/qcom/lpass-lpaif-reg.h                   | 157 >> ++++++++------- >>   sound/soc/qcom/lpass-platform.c                    | 155 >> +++++++++++---- >>   sound/soc/qcom/lpass-sc7180.c                      | 216 >> +++++++++++++++++++++ >>   sound/soc/qcom/lpass.h                             |  63 +++++- >>   12 files changed, 930 insertions(+), 299 deletions(-) >>   delete mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>   create mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >>   create mode 100644 include/dt-bindings/sound/sc7180-lpass.h >>   create mode 100644 sound/soc/qcom/lpass-sc7180.c >> -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.