Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Jul 2020 11:23:17 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Mike Looijmans <mike.looijmans@topic.nl>
Cc:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        balbi@kernel.org, gregkh@linuxfoundation.org, lgirdwood@gmail.com
Subject: Re: [PATCH v3] usb: dwc3: Add support for VBUS power control
Message-ID: <20200727102317.GA6275@sirena.org.uk>
References: <20200619142512.19824-1-mike.looijmans@topic.nl>
 <20200723075612.tn5dbkhes2chohwh@axis.com>
 <20200723110523.GA4759@sirena.org.uk>
 <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.2698920d-90ba-4c46-abda-83e18e2093c8@emailsignatures365.codetwo.com>
 <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.0d2bd5fa-15cc-4b27-b94e-83614f9e5b38.ac9c2a67-d7df-4f70-81b3-db983bbfb4db@emailsignatures365.codetwo.com>
 <e63ee918-c9e3-a8ee-e7c5-577b5a3e09be@topic.nl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX"
Content-Disposition: inline
In-Reply-To: <e63ee918-c9e3-a8ee-e7c5-577b5a3e09be@topic.nl>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--huq684BweRXVnRxX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jul 26, 2020 at 09:10:39AM +0200, Mike Looijmans wrote:
> On 23-07-2020 13:05, Mark Brown wrote:

> > Does the device actually support running without power so that's a thing
> > that can happen?  _get_optional() should only ever be used for supplies
> > that may be physically absent.

> It's the 5V VBUS power for the USB "plug" that's being controlled here. It
> must turned on when the controller is in "host" mode. Some boards arrange
> this in hardware through the PHY, and some just don't have any control at
> all and have it permanently on or off. On a board where the 5V is controlled
> using a GPIO line or an I2C chip, this patch is required to make it work.

That sounds like the driver should not be using _get_optional() then.

--huq684BweRXVnRxX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8eqxQACgkQJNaLcl1U
h9D37gf+MqVp+KCPE5nCp6z56WtbbJ2SsaT2cXZ4Bu/Tftpv5fJXImgfZVXoiMo8
izzNNNSlBbUvB4O9eBb5M303A+ObHHVGTYkZ7L2HO87ulhK3y0Xj/8mXti+IatXD
uRLB4S5p4mf4tVxQYtWB7ipPMTfwrc3EpqnEb6pScY4OTtshbBoJH5sBKI6h2qnf
5NRbXA7INPlp/nnobxhy1PL4sPs3sI8PCaBXbTWA+Kb/g8vVLUSGi32/zDTtjL2U
niI6uey6i9PwraKfP+ZaU280nuoHd0zrs7MnGXuUcP0sxgd7NIRYQ7DMs/hhIhF4
ebDKZ3eJuHkhhVWxU2ukURV5h+LOcw==
=OkVm
-----END PGP SIGNATURE-----

--huq684BweRXVnRxX--