Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Parav Pandit <parav@mellanox.com>
To:     Li Heng <liheng40@huawei.com>, Jason Gunthorpe <jgg@mellanox.com>,
        "dledford@redhat.com" <dledford@redhat.com>
CC:     "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/core: fix return error value to negative
Thread-Topic: [PATCH] RDMA/core: fix return error value to negative
Thread-Index: AQHWYi8CMNZFniXLvUG1VkRM5rCJo6kbPgdQ
Date:   Mon, 27 Jul 2020 10:36:29 +0000
Message-ID: <AM0PR05MB4866C7A9773DD28AB8ED7708D1720@AM0PR05MB4866.eurprd05.prod.outlook.com>
References: <1595645787-20375-1-git-send-email-liheng40@huawei.com>
In-Reply-To: <1595645787-20375-1-git-send-email-liheng40@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a9fbb55-466d-476c-7eac-08d83218ec59
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 10:36:29.7907
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DeGFq3Cn9s0EOp/BaK/7WvokySN17QvgbiTkiX6+AH8TphDe1hkRJp1WKNzP1fEs6THXAoz2fZPTkAGuC9X16Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5746
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: linux-rdma-owner@vger.kernel.org <linux-rdma-owner@vger.kernel.org>
> On Behalf Of Li Heng
> Sent: Saturday, July 25, 2020 8:26 AM
>=20
> Fixes: 8d9ec9addd6c (IB/core: Add a sgid_attr pointer to struct rdma_ah_a=
ttr)
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Li Heng <liheng40@huawei.com>
> ---
>  drivers/infiniband/core/verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/ve=
rbs.c
> index 53d6505c..f369f0a 100644
> --- a/drivers/infiniband/core/verbs.c
> +++ b/drivers/infiniband/core/verbs.c
> @@ -1712,7 +1712,7 @@ static int _ib_modify_qp(struct ib_qp *qp, struct
> ib_qp_attr *attr,
>  		if (!(rdma_protocol_ib(qp->device,
>  				       attr->alt_ah_attr.port_num) &&
>  		      rdma_protocol_ib(qp->device, port))) {
> -			ret =3D EINVAL;
> +			ret =3D -EINVAL;
>  			goto out;
>  		}
>  	}
> --
> 2.7.4

With below corrected fixes tag,

Fixes: 7a5c938b9ed0 ("IB/core: Check for rdma_protocol_ib only after valida=
ting port_num")
Reviewed-by: Parav Pandit <parav@mellanox.com>