Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Jul 2020 12:11:09 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Clark Wang <xiaoning.wang@nxp.com>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/4] spi: lpspi: Fix kernel warning dump when probe
 fail after calling spi_register
Message-ID: <20200727111109.GB6275@sirena.org.uk>
References: <20200727031448.31661-1-xiaoning.wang@nxp.com>
 <20200727031448.31661-2-xiaoning.wang@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="XOIedfhf+7KOe/yw"
Content-Disposition: inline
In-Reply-To: <20200727031448.31661-2-xiaoning.wang@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--XOIedfhf+7KOe/yw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 27, 2020 at 11:14:46AM +0800, Clark Wang wrote:
> Calling devm_spi_register_controller() too early will cause problem.
> When probe failed occurs after calling devm_spi_register_controller(),
> the call of spi_controller_put() will trigger the following warning dump.
>=20
> [    2.092138] ------------[ cut here ]------------
> [    2.096876] kernfs: can not remove 'uevent', no directory
> [    2.102440] WARNING: CPU: 0 PID: 181 at fs/kernfs/dir.c:1503 kernfs_re=
move_by_name_ns+0xa0/0xb0
> [    2.111142] Modules linked in:
> [    2.114207] CPU: 0 PID: 181 Comm: kworker/0:7 Not tainted 5.4.24-05024=
-g775c6e8a738c-dirty #1314
> [    2.122991] Hardware name: Freescale i.MX8DXL EVK (DT)
> [    2.128141] Workqueue: events deferred_probe_work_func

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--XOIedfhf+7KOe/yw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8etkwACgkQJNaLcl1U
h9By2AgAgnTCFAi+3XM31B5xy1B70aDoOYf1tRMaXEQR97aYIRF+ihcgFzNIsmrH
E3lMnfNkmIdmCHpJpRyfgdH+zIMbya8rvWnQwiO60Ar+weSi6cB9cuRY/OvpKDQp
oz/4iFuOMzLB/+d8OABUsT1NlxvJGZR55VxQyCtWLXWCl47Qw53g5BS5iHSK0vSt
Qnlh/I+gGGdZ3AV/d6F5LlG0/ogsM0GW9qL06b5MBKHje93LJJao6YOczrYN2RIL
9Zt5nJ3a5BqgduNsas5XrxWjQ3QV00AIPwdKXziIhxMcQBmGv3r3dYpDQELHU5nr
WxgW50uDCZtetlfOcgTBIt4UREDmgQ==
=umFf
-----END PGP SIGNATURE-----

--XOIedfhf+7KOe/yw--