Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200727030407.8820-1-vulab@iscas.ac.cn> <20200727120908.GR3703480@smile.fi.intel.com>
 <20200727125335.GQ1850026@dell>
In-Reply-To: <20200727125335.GQ1850026@dell>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 27 Jul 2020 16:00:24 +0300
Message-ID: <CAHp75Vfi4pC0rQHVmi6nuQ12tL7shtKPbbSuFgBhD-jDs_Z=+A@mail.gmail.com>
Subject: Re: [PATCH] intel_soc_pmic_mrfld: simplify the return expression of intel_scu_ipc_dev_iowrite8()
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Xu Wang <vulab@iscas.ac.cn>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 27, 2020 at 3:57 PM Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 27 Jul 2020, Andy Shevchenko wrote:
> > On Mon, Jul 27, 2020 at 03:04:07AM +0000, Xu Wang wrote:

...

> > It's a bit more helpful in the original form in case to add some debugging.
>
> If you wish to add debugging, you'll have to add the extra line of
> code yourself. :)

True, that's why I'm not objecting the change.

> > It also keep it symmetrical with read() counterpart.
>
> Can this be fixed-up too?

How? Can you elaborate?

> > That said, I'm not objecting the change if Lee finds it good enough.

-- 
With Best Regards,
Andy Shevchenko