From: Andi Kleen <ak@suse.de>
To: Avi Kivity <avi@argo.co.il>
Subject: Re: [RFC PATCH 17/35] Segment register changes for Xen
Date: Thu, 11 May 2006 12:41:25 +0200
User-Agent: KMail/1.9.1
Cc: Pavel Machek <pavel@suse.cz>, virtualization@lists.osdl.org,
       Chris Wright <chrisw@sous-sol.org>, xen-devel@lists.xensource.com,
       linux-kernel@vger.kernel.org, Ian Pratt <ian.pratt@xensource.com>
References: <20060509084945.373541000@sous-sol.org> <20060510203015.GA13949@elf.ucw.cz> <4463133A.8060806@argo.co.il>
In-Reply-To: <4463133A.8060806@argo.co.il>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605111241.26252.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 898
Lines: 31

On Thursday 11 May 2006 12:34, Avi Kivity wrote:
> Pavel Machek wrote:
> > Really? If someone does 
> >
> > 	if (something)
> > 		clearsegment(seg)
> > 	somethingelse();
> >
> > ... he'll get very confusing behaviour instead of compile error. 
> >
> > Okay, that's weaker argument than expected...
> >
> > Also clearsegment(x) clearsegment(y); will compile when it should not.
> >
> > Also clearsegment(i++) will behave strangely. So perhaps 
> >
> > #define clearsegment(seg) do { seg; } while (0)
> >   
> 
> static inline void clearsegment(int seg) {}


It's all mood because the complete function is wrongly named
and probably should just go.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/