Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Jul 2020 14:26:36 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Xu Wang <vulab@iscas.ac.cn>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] intel_soc_pmic_mrfld: simplify the return expression of
 intel_scu_ipc_dev_iowrite8()
Message-ID: <20200727132636.GR1850026@dell>
References: <20200727030407.8820-1-vulab@iscas.ac.cn>
 <20200727120908.GR3703480@smile.fi.intel.com>
 <20200727125335.GQ1850026@dell>
 <CAHp75Vfi4pC0rQHVmi6nuQ12tL7shtKPbbSuFgBhD-jDs_Z=+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75Vfi4pC0rQHVmi6nuQ12tL7shtKPbbSuFgBhD-jDs_Z=+A@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 27 Jul 2020, Andy Shevchenko wrote:

> On Mon, Jul 27, 2020 at 3:57 PM Lee Jones <lee.jones@linaro.org> wrote:
> > On Mon, 27 Jul 2020, Andy Shevchenko wrote:
> > > On Mon, Jul 27, 2020 at 03:04:07AM +0000, Xu Wang wrote:
> 
> ...
> 
> > > It's a bit more helpful in the original form in case to add some debugging.
> >
> > If you wish to add debugging, you'll have to add the extra line of
> > code yourself. :)
> 
> True, that's why I'm not objecting the change.
> 
> > > It also keep it symmetrical with read() counterpart.
> >
> > Can this be fixed-up too?
> 
> How? Can you elaborate?

I hadn't even looked at the code before my reply.  I just assumed it
was in a similar situation.

Now I have looked at it, could the pointer to the return value be
cast?

If not, just leave it.  Symmetry isn't a good measure of good, clean
code.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog