Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp4876236pjb; Mon, 27 Jul 2020 07:23:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAJfNExjomBLn0pl+ICB4tkR9uerBcwmjTtgs82UTl9giGduQON1F/xOQIQpfznovAwn3g X-Received: by 2002:a50:acc5:: with SMTP id x63mr20876385edc.99.1595859783422; Mon, 27 Jul 2020 07:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595859783; cv=none; d=google.com; s=arc-20160816; b=Ij9nEBJ8DgG3l1wboDMTg3miMdDqwRzUws06qZfVHJDNuPiQ40HlgvFmBlchAffHTg bfQh4ew9KydA6ytLtn+ywYS637iuXw6E/l9iMuZOv93yrqdTphIubt/MwWBiSBZCO+al ynBJFGengaYCTOMgH9KKQeKLHs29ZcaRG/D0KA2hHWl4HBH8bvecyTy4LqNAEoSKuuTC AZMwMCNw2BBqcBaOlv//GwGwUIW6FYuj4UnfchhrXlCWb/NJ5txde56lqC7nEBib4d9K jV2OpMLB1Nh3jNDbcKurQyjdUCwfIvOevAtDzPbS/8ind8EmBQOISbSohBeSLNzUeCPt Fqww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZIxMgsI/2FSQ/x/V26i1fKBO4JY6+JCPweEEnkZlvHw=; b=gRqQSKmNlUiRe8wLxZNJcmkeDFUyBHjUuAtNh49erJx/sLIkaYwXU5tmH8FeF+dTO+ grXQ18P21Cjn+JgvkVnnxFYnk8lC1leNFAaptkW3x9Qj+VYX2vljkNm1yGJgJvNLiyv+ D/4YHaFd8Vug2rXj8YkKtqOK+SFXOfvRof3D+SNMR9HiwceLSi6qEDyoupG0Rj0Ql/YX tQPxMUt54b3Usr5CqQojV90WduFNu2alpxNmZb+s8LxAnpJxUx5lY1lQP0zSHK1R5GOR oxmx9cTq8f1buxSfvhhLsCWR/b99TnMFEE03qjwZWQADnuUEsc091zWT2KmTddSOVGzj fLlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MAkOnfsZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si3473222edw.98.2020.07.27.07.22.39; Mon, 27 Jul 2020 07:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MAkOnfsZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731497AbgG0OUF (ORCPT + 99 others); Mon, 27 Jul 2020 10:20:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:48202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731489AbgG0OUC (ORCPT ); Mon, 27 Jul 2020 10:20:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08B9F2070A; Mon, 27 Jul 2020 14:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859602; bh=pNZ5dqteI6Mnoc1TUKncTKofJ2ZiWdSCFdqSL3JX16o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MAkOnfsZ5878g1X0ORc6Eyn5rnQafwF9kEigScEPgBxsLwBwhJeDNitp9HQJ6O96I 2y2nbouHpyvyigEFyz70kiVX6X+cq9iyZsZ6Gr2ZYII+qyr/waylGjR7z+NcCUuAxm plGS1HR0gH7MyZR8VEc059Hwaf91/VmCL23TkaLE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Mark Brown Subject: [PATCH 5.7 035/179] ASoC: rt5670: Correct RT5670_LDO_SEL_MASK Date: Mon, 27 Jul 2020 16:03:30 +0200 Message-Id: <20200727134934.379751379@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134932.659499757@linuxfoundation.org> References: <20200727134932.659499757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans de Goede commit 5cacc6f5764e94fa753b2c1f5f7f1f3f74286e82 upstream. The RT5670_PWR_ANLG1 register has 3 bits to select the LDO voltage, so the correct mask is 0x7 not 0x3. Because of this wrong mask we were programming the ldo bits to a setting of binary 001 (0x05 & 0x03) instead of binary 101 when moving to SND_SOC_BIAS_PREPARE. According to the datasheet 001 is a reserved value, so no idea what it did, since the driver was working fine before I guess we got lucky and it does something which is ok. Fixes: 5e8351de740d ("ASoC: add RT5670 CODEC driver") Signed-off-by: Hans de Goede Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20200628155231.71089-3-hdegoede@redhat.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/codecs/rt5670.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/codecs/rt5670.h +++ b/sound/soc/codecs/rt5670.h @@ -757,7 +757,7 @@ #define RT5670_PWR_VREF2_BIT 4 #define RT5670_PWR_FV2 (0x1 << 3) #define RT5670_PWR_FV2_BIT 3 -#define RT5670_LDO_SEL_MASK (0x3) +#define RT5670_LDO_SEL_MASK (0x7) #define RT5670_LDO_SEL_SFT 0 /* Power Management for Analog 2 (0x64) */