Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp4876567pjb; Mon, 27 Jul 2020 07:23:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzK4qD7Mh7L4wOLOoaB11+MRkY/mxncQLFdFgniU5CTR3q/upqwf5Xbp4kNWRc9IyJ88gyI X-Received: by 2002:a17:906:7250:: with SMTP id n16mr22101550ejk.290.1595859812220; Mon, 27 Jul 2020 07:23:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595859812; cv=none; d=google.com; s=arc-20160816; b=UW8zoCFm8H25/0FI38hGk0HA5Zs5U5YhTgSpoWMgWZzss8YTjgPgtXT6qRb1Z3sWzb 5+pMAXbsr6KZZrarApNCOuxovG4z1LxQXDW7Vp75in7oKyc4lu7dUazIXF6ofhwbJQQP UPq0zNM9GwZrvfCRCxDTlA4XwsTI4r/uLQ4PSHQDiOuSpRDun/EicC+I5Wif/YqsSnX/ 1uChpB6goJXndkVG61oalIHCRLo4BRwnS32anTybsPzFIJbV8GqG2i6a94idq29rMIj0 P8fE+eVLEa+ByO2KIpS/UcuCQ4MXeBpa2Jf2DH0/5WSkXXsadUNivWyJ41B8f2L2qBoi ghHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=q1FxAz5/lvDIDUqVytA040ns/TpfQPPqqf3eZU7WUBM=; b=qawJZgIBQa7c1er8Zvq+KzIbljH21MW+YwlxwPAWpCpmn+B9fgnrNIcdiJ79KFQDi1 41wQNqEh+uM4w4flmCEhXINa+obuEJbbImPUT7rvuIkuZ9zA+QTfoOr3m8eJffG9VvSs didjxQd08mzHnIVJrNv8yG1RrAW2WgLIkgpvD7m5296x3xGjFisBI2bDM5pcTM+Fi8Fu iib+IVcvQDBZ3A1o3XpekefaDg03YfuGqSeLi6ohD4c3Ii1XFg+qHlCWQcNaSesmUVjH HrQTUorCPRquA+SSUpTedfHrCvXcnFAeMMWutAF5yT/mVeVDd5yfTDVtDKRp2iQVjEkZ 0KXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d2y35ICl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e2si5949034edv.556.2020.07.27.07.23.09; Mon, 27 Jul 2020 07:23:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d2y35ICl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731758AbgG0OVs (ORCPT + 99 others); Mon, 27 Jul 2020 10:21:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:50490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730258AbgG0OVq (ORCPT ); Mon, 27 Jul 2020 10:21:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8778A2070A; Mon, 27 Jul 2020 14:21:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859706; bh=9wNdLFe2Mc0qAiEK+P603wJC8PshkNcKQvnyLiY81/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d2y35IClG6sYTM37tVh1ksFWFTNOeCszvdU5kc4Xf2WaCpyj25Q6SmQTcJ/m8lbJx Y5WCFraQUgvpc8J/VgE3+YABWVfCxealk31V5t3DB49hJLy32JKuB2ACp8ELou/XqT LQ05jWPrK5Ei61CJmrelD1s1U24oZYOrkNb9NHtg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shannon Nelson , "David S. Miller" , Sasha Levin Subject: [PATCH 5.7 073/179] ionic: keep rss hash after fw update Date: Mon, 27 Jul 2020 16:04:08 +0200 Message-Id: <20200727134936.238606592@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134932.659499757@linuxfoundation.org> References: <20200727134932.659499757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shannon Nelson [ Upstream commit bdff46665ee655600d0fe2a0e5f62ec7853d3b22 ] Make sure the RSS hash key is kept across a fw update by not de-initing it when an update is happening. Fixes: c672412f6172 ("ionic: remove lifs on fw reset") Signed-off-by: Shannon Nelson Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index 48aa502e4bd3d..08ab6dafc66c5 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -2227,11 +2227,10 @@ static void ionic_lif_deinit(struct ionic_lif *lif) cancel_work_sync(&lif->deferred.work); cancel_work_sync(&lif->tx_timeout_work); ionic_rx_filters_deinit(lif); + if (lif->netdev->features & NETIF_F_RXHASH) + ionic_lif_rss_deinit(lif); } - if (lif->netdev->features & NETIF_F_RXHASH) - ionic_lif_rss_deinit(lif); - napi_disable(&lif->adminqcq->napi); ionic_lif_qcq_deinit(lif, lif->notifyqcq); ionic_lif_qcq_deinit(lif, lif->adminqcq); -- 2.25.1