Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp4885134pjb; Mon, 27 Jul 2020 07:34:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWzyV2UvwaxPSgIKlcH151ioGfbHorNBzEKSNYuU81kWIpP7vOrn0+2zAKO5PfSlfe05XX X-Received: by 2002:a17:906:c1c3:: with SMTP id bw3mr13251194ejb.8.1595860491187; Mon, 27 Jul 2020 07:34:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595860491; cv=none; d=google.com; s=arc-20160816; b=t8nDTHZxhEj1izTbNiLTbUuqYNRb4F+Y2cR6ASl2p6qhdf9VrBSn3f6lpAs8ekperA 6X4mlBLa5Sqqaj+RHOzrwQwnLt7D3J23/hQciAecNBYSYCB8RrnnEb7MZdqC5X0jclWn 2DcQz2MD62X6M9+zyNCB3crQuvR4U8nAEXHYwI4OpMlCQMtQG8mjSJ+RR6VroMOftStJ 80bhtXI/89KVm5j3IH6PtptLkUXhMJcJUzo2rDIZG0wD3A2RV3H97KfzQutoyV5mcMMg j08LrKQHHM9TYEaI/+5U/MAC/HxohnCM3UMOXR4VqCox+7JdseQfj++8Th/n2cqM82uE T/Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pdu33YGvLQelxiiszCoZQ2W0JWfTaGN4y1VfiZcKCVg=; b=sLIFHE83KlDYIe9JSKmlVcXpVbNTQPYYo0dl3DmnBRRT1GH50pQyKNwV2zZqDNrvtn H0TJk9Qx7BbkwgpLUZ3ori2i0HYPI/l14hZIqiosrrMRDnwcefx7VkwZimQ46rkYdoID iTkNiqvaZDlJBawdmNyZJhtt94gNONJ2nQ0sWrWH0IJd1xKjCogVkvBPA7KpaACBikKu 9SPw2EE3S6g8Bmga8bUG5T+BnPNZkzlvX8aJbzUMw/Z7FYJRrFlznSYAUlh/Sy776oCn +2oxlkGuUYxdHsJJyBsRtMUDFSTPv9vq17mjFL/cFoL31u70FxcDFbdyzrbeYmbzapjf vXUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hFc1VBzK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y24si4437607eje.87.2020.07.27.07.34.29; Mon, 27 Jul 2020 07:34:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hFc1VBzK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732788AbgG0ObQ (ORCPT + 99 others); Mon, 27 Jul 2020 10:31:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:49356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731626AbgG0OUy (ORCPT ); Mon, 27 Jul 2020 10:20:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DAD22070B; Mon, 27 Jul 2020 14:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859653; bh=uHBTrMrYml8VaPhAjZRyOEWnDq3qelk0BaB3G42UzUs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hFc1VBzKXTnZXoVBBFlMC8KhviQ+uWLtRa5Juibcxmdjv+5x/kgHpJ0iIR8J+28fR N9DhnPZH0crGzYiwK4YwoqeafRHOAJfZCwSEi3I1E0pUPGLVa1JXq+XDDFI47ynAEM DSSEHGHIVUQMxRm9+BWQe9gu7IoL5NMkVk6z47XU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alex Deucher , Nicholas Kazlauskas , Aaron Ma , Sasha Levin Subject: [PATCH 5.7 023/179] drm/amd/display: add dmcub check on RENOIR Date: Mon, 27 Jul 2020 16:03:18 +0200 Message-Id: <20200727134933.798087986@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134932.659499757@linuxfoundation.org> References: <20200727134932.659499757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aaron Ma [ Upstream commit 3b2e973dff59d88bee1d814ddf8762a24fc02b60 ] RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram, it breaks backlight control. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=208277 Acked-by: Alex Deucher Reviewed-by: Nicholas Kazlauskas Signed-off-by: Aaron Ma Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 7da2a22dbde7e..837a286469ecf 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1345,7 +1345,7 @@ static int dm_late_init(void *handle) struct dmcu *dmcu = NULL; bool ret; - if (!adev->dm.fw_dmcu) + if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw) return detect_mst_link_for_all_connectors(adev->ddev); dmcu = adev->dm.dc->res_pool->dmcu; -- 2.25.1