Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp4885790pjb; Mon, 27 Jul 2020 07:35:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymxsdFTM4uCR7nxrgy7nHLBoBiodk/DwqSNVuv7muwBq75nywU83GoHdT3QmhB0SK4fTao X-Received: by 2002:aa7:ca10:: with SMTP id y16mr14907793eds.345.1595860544500; Mon, 27 Jul 2020 07:35:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595860544; cv=none; d=google.com; s=arc-20160816; b=cYEJ4pFrQIQGPWwsLk3lTR/nW3VCrq8mcLpwLw8hLe1vY63VaFBkEucSggfs7taeDf SEAeTRoyoYcOrhqfoD3k++ekhUoPRCOkX2RkjQnC6JuXhGzMgdhmDH5stxbWrbUxrEVm JTC9mlX2qp0Jx0n3H8hljDlUCILBOJkS3ubrhkcL3JVvSRQH0MS+T9haFcf7FFM4hthi FSGeDXojtaVRBrOGhMWhfrwBnhgnEmXtaevOnEMNRYNMHbZW2aUtpRPTbe1OjZN00SIT vG1wAqZ925sCqXKtFYW6qcqySipv3EuPBfRFQB8njjG4FUMncKGAFqty0mn1seW53o5N 1IGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :reply-to:dkim-signature; bh=Yrmg7GloPR9Hiyo5qyAm1IqrG/9D+0W+PwlomhSFTYc=; b=u3N8eXPxm40GbhmKDvdxlSFtrHjCSPz0/RKIlo1TMdTNrfaf2UvL1AdmOWeJLvPQc1 Md6iL1rL2UC+AivacEdRzj7tA6qRodh1jqr9ZMYBqGgX1athVpQZUeD2RmNr7PbBmjSt sKiWJcpp/LHn5mxv9yW1SCC451dW0xCPrEy5rCe6mQqOkF1zxJiEB9wrM7uECknzBdPm RPCa7tB34EEjERmhd+2PQDOIFjUooXUzV/JMDTGJDPRWr3sfyZrevJmELN6U0uRS+ry7 0pnFV+hg3m1yQ/RMv1FhlEYoJhNUxvKzvaqYCHq1QSvxXcr8jxY0YePxth29PoDMLac8 qbhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=RFPMr7FA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p90si5624641edd.468.2020.07.27.07.35.22; Mon, 27 Jul 2020 07:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=RFPMr7FA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732796AbgG0Obm (ORCPT + 99 others); Mon, 27 Jul 2020 10:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732225AbgG0Obk (ORCPT ); Mon, 27 Jul 2020 10:31:40 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D94C4C061794; Mon, 27 Jul 2020 07:31:39 -0700 (PDT) Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A2FB39B1; Mon, 27 Jul 2020 16:31:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1595860297; bh=IMioECjXrO1BEPObj3Q0AqDHaxcQ3XVAMod0E8EVubw=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=RFPMr7FAJG+iVSKzZTr7FTR4hKWrXYxFeUzvPdtJ9JG69DC3iRMoua5PLdojZc6on 56WXwb4FrmaqhoWuLXJ/ZrVL0VW9H46NdoE8ivflmZJaQsjD1WwAgHPFWyyMxb1Ake YUo2tBj8/kV1KcGfuJDArUrI1mE0a+T31cmEbkWE= Reply-To: kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 0/3] media: vimc: Allow multiple capture devices to use the same sensor To: Kaaira Gupta , =?UTF-8?Q?Niklas_S=c3=b6derlund?= Cc: Helen Koike , Shuah Khan , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Dafna Hirschfeld References: <20200724120213.17119-1-kgupta@es.iitr.ac.in> <20200724121521.GA2705690@oden.dyn.berto.se> <20200724122104.GA18482@kaaira-HP-Pavilion-Notebook> From: Kieran Bingham Autocrypt: addr=kieran.bingham@ideasonboard.com; keydata= mQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat V/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC rRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C potzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ cSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf Kr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8 RXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko lPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq 8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36 Oe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu Z2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI BwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ CyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm VsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S QK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG YZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS enKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ BmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp aScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH fA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H QGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD hXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m ARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz tih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI d6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6 mhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl En1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5 PKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R +rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk NlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04 /UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L oeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/ vSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD MJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj 6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz PZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp ECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx S0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j sbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8 pQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc MW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU AfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4 WZw01QYHU/GUV/zHJSFk Organization: Ideas on Board Message-ID: Date: Mon, 27 Jul 2020 15:31:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200724122104.GA18482@kaaira-HP-Pavilion-Notebook> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, +Dafna for the thread discussion, as she's missed from the to/cc list. On 24/07/2020 13:21, Kaaira Gupta wrote: > On Fri, Jul 24, 2020 at 02:15:21PM +0200, Niklas Söderlund wrote: > Hi, > >> Hi Kaaira, >> >> Thanks for your work. > > Thanks for yours :D > >> >> On 2020-07-24 17:32:10 +0530, Kaaira Gupta wrote: >>> This is version 2 of the patch series posted by Niklas for allowing >>> multiple streams in VIMC. >>> The original series can be found here: >>> https://patchwork.kernel.org/cover/10948831/ >>> >>> This series adds support for two (or more) capture devices to be >>> connected to the same sensors and run simultaneously. Each capture device >>> can be started and stopped independent of each other. >>> >>> Patch 1/3 and 2/3 deals with solving the issues that arises once two >>> capture devices can be part of the same pipeline. While 3/3 allows for >>> two capture devices to be part of the same pipeline and thus allows for >>> simultaneously use. >> >> I'm just curious if you are aware of this series? It would replace the >> need for 1/3 and 2/3 of this series right? > > v3 of this series replaces the need for 1/3, but not the current version > (ie v4). v4 of patch 2/5 removes the stream_counter that is needed to > keep count of the calls to s_stream. Hence 1/3 becomes relevant again. So the question really is, how do we best make use of the two current series, to achieve our goal of supporting multiple streams. Having not parsed Dafna's series yet, do we need to combine elements of both ? Or should we work towards starting with this series and get dafna's patches built on top ? Or should patch 1/3 and 3/3 of this series be on top of Dafna's v4 ? (It might be noteworthy to say that Kaaira has reported successful multiple stream operation from /this/ series and her development branch on libcamera). >> 1. https://lore.kernel.org/linux-media/20200522075522.6190-1-dafna.hirschfeld@collabora.com/ >> >>> >>> Changes since v1: >>> - All three patches rebased on latest media-tree. >>> Patch 3: >>> - Search for an entity with a non-NULL pipe instead of searching >>> for sensor. This terminates the search at output itself. >>> >>> Kaaira Gupta (3): >>> media: vimc: Add usage count to subdevices >>> media: vimc: Serialize vimc_streamer_s_stream() >>> media: vimc: Join pipeline if one already exists >>> >>> .../media/test-drivers/vimc/vimc-capture.c | 35 ++++++++++++++++++- >>> .../media/test-drivers/vimc/vimc-debayer.c | 8 +++++ >>> drivers/media/test-drivers/vimc/vimc-scaler.c | 8 +++++ >>> drivers/media/test-drivers/vimc/vimc-sensor.c | 9 ++++- >>> .../media/test-drivers/vimc/vimc-streamer.c | 23 +++++++----- >>> 5 files changed, 73 insertions(+), 10 deletions(-) >>> >>> -- >>> 2.17.1 >>> >> >> -- >> Regards, >> Niklas Söderlund -- Regards -- Kieran