Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1094316ybg; Mon, 27 Jul 2020 07:47:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh2arNoS0mSWpt2qmdVwHMACHHwKY1hQZTTQ0vcCYCF0L7tK4zeTugpZn9W7L54bGSSn0F X-Received: by 2002:a17:906:4c46:: with SMTP id d6mr14016758ejw.14.1595861228543; Mon, 27 Jul 2020 07:47:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595861228; cv=none; d=google.com; s=arc-20160816; b=zrvdSuicyLDkI8Z/McbazFGHpquFBqBQAkQbKGDOQgtI7Qiyg+CPFlkCS2qJX4QaDj +jRi1ZNwPaJQaoEmo4iDByoTEK2tM+EzW86mrEntTr7YqBz8XfAEibJXF5Qo+QBEb0w+ OXNCWSW/Iaevqd4jVoPwqPJ0UrZPe8x2yOD2WxuIaJEvjcPvXLmS23EiIIPucYp7w77L oAFN/bSUo8rTsvp2/ZI/7h6v8Tx5bJX3KmHQPoAseHD/AB8A7/KV1GkL5gv7LwMMx9hG tla7MDYAIAEUxGC+86Ej09wJPOEyqoYpeA07UdR5b3ipb4O0bBvQc7h7AJoRs/Wv+p4Z FnIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XZwDFP7/Bk7zQbeafucYS3tZ79YR2yepxvTQrzg7myI=; b=eWnCUP8aLuvADMUcrDHTFa7W8dmoa4mmTeJTKQPS/CVp5cncUtSP4OfCWJRbn/YH7s vQIJ+MS/3Bg4wTiQTXPFFFCyGe6pM8lrGVcWGCmwyc716RsUnLUew+Mv5AnMU/1PuHgX RXPxWxN9fsyQwjLMxdkk5LwFEiX5ANDuNUDMhe+1Ak8NjkaOIBdncGwhlUftae1cwaf4 EUCLF3uaz5k0dy1Zw3FIRtW9zKUNlrm+tOF4rbyKUYFHc86RYgoyhqyQnPxrzfzHxlPF 75lrau7Ywg2Drfr+OffvJHk3rnRVqRbPl/Vpl07ULgnd12dB98u3zLTNNSMW4mU2ea+o 99nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=HUSvyOs+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si5744223ede.534.2020.07.27.07.46.45; Mon, 27 Jul 2020 07:47:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=HUSvyOs+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729055AbgG0Oqf (ORCPT + 99 others); Mon, 27 Jul 2020 10:46:35 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:51526 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728314AbgG0Oqf (ORCPT ); Mon, 27 Jul 2020 10:46:35 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06REVmaZ087477; Mon, 27 Jul 2020 14:46:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=XZwDFP7/Bk7zQbeafucYS3tZ79YR2yepxvTQrzg7myI=; b=HUSvyOs+R8abvlti5/CYCUsc1Mun5agLKVhE1J1FYLAAeUJlNpRpQZICRy3PXxpK/oA4 emDk2wTO26NGj2FfHLKWZVeO7GphKusAf6DeZSjixEatmThFucWRrkoZGBgjovp2kzA2 zNXdlKF7Z2OinXOHmL2XssewXx8zNb66bVZAEV7RxZ1ByL12T29HT4l4JHGKSmqOlXkh eo/diz1WnEyyVgHe2eJefifzeyjF+2abfJMMft+xY49tGExm8n6vQVYTw9Ir/OeVS1cK kTx87K5xgctwCJObs8wYtxTq1y9DPKJDDzXzo23MnOOzp4FGuwCp+pXRsMb3WprhiroC Aw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 32hu1j9ysc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 27 Jul 2020 14:46:22 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06REiONS085503; Mon, 27 Jul 2020 14:46:21 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 32hu5qv06y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jul 2020 14:46:21 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06REkIMi026768; Mon, 27 Jul 2020 14:46:18 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 27 Jul 2020 07:46:18 -0700 Date: Mon, 27 Jul 2020 17:46:09 +0300 From: Dan Carpenter To: Peilin Ye Cc: Arnd Bergmann , Mauro Carvalho Chehab , Greg Kroah-Hartman , syzkaller-bugs , Hans Verkuil , Sakari Ailus , Laurent Pinchart , Vandana BN , Ezequiel Garcia , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-kernel-mentees@lists.linuxfoundation.org, Linux Media Mailing List , "linux-kernel@vger.kernel.org" , Linus Walleij Subject: Re: [Linux-kernel-mentees] [PATCH v3] media/v4l2-core: Fix kernel-infoleak in video_put_user() Message-ID: <20200727144609.GG1913@kadam> References: <20200726220557.102300-1-yepeilin.cs@gmail.com> <20200726222703.102701-1-yepeilin.cs@gmail.com> <20200727131608.GD1913@kadam> <20200727141416.GA306745@PWN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727141416.GA306745@PWN> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9695 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007270104 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9694 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 mlxlogscore=999 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007270104 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 10:14:16AM -0400, Peilin Ye wrote: > Yes, I would like to! I will start from: > > drivers/firewire/core-cdev.c:463 My prefered fix for this would be to add a memset at the start of fill_bus_reset_event(). memset(event, 0, sizeof(*event)); spin_lock_irq(&card->lock); event->closure = client->bus_reset_closure; > drivers/input/misc/uinput.c:743 I don't think this is a bug. regards, dan carpenter