Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp5056838pjb; Mon, 27 Jul 2020 11:48:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykm6TZaCNy12bNdrNxifBaZ2LA5qUQACaj6eLH4hGIPRZYkv4AoB2srRN54EYkjyjWJDg0 X-Received: by 2002:aa7:dd14:: with SMTP id i20mr23494765edv.41.1595875686820; Mon, 27 Jul 2020 11:48:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595875686; cv=none; d=google.com; s=arc-20160816; b=Lfi88MjKjk+n+JxYTgInJgHqnm+ELeoOCug4I5EnRK/T+iAMsutPJI8aHFken6RzIC u15+14d1CO5nVj+Q5tG1IRoNGYV2t7WbfoGP151XEeLXSPfauI5gTXFdbf/GZNPYmHmH 1GtUWoMNzx9A7C0WotlXBiCVi207fSFG8nErAQrgVW4TiJfGm7hS72rIw+cUHZiYb8xn oNz8qAzdhsegWLkL5oqYrJYLokyGsnMrjzCV31oxzyDIV0nErUp9t494/ScjlX6ujLea 5hj2uZ+ENS/85rzAvH+gc2UQg4BTMsr3jXDbPeWgRqEzoBD59NVtVDv7x17iGVt3NaFO b1TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Lo4uf6Sx9PxbJQwC7BxSe3Ns3cZ6S8nqOZCR8arlrtw=; b=KpWx+G/m+QM/gSRxbSUkyRVTzQWYobNwMs6tdNi3n0o0Y/fii0zcn+KaK+EDWadCeK GK63FwxCmH3kxYxqrFlCGhm6jj4ZEcFTo9/xeSOyWEl59HzzOFM3ierCWVmxGfBY/iSi AYmGT5aQyb92j1M17gBG5aD/JPMeY7yKDCTIamE+AHcXDKrQpvJWm2+Y3y0W56W2jgzk vSSanyKgcBk45AV7Hu13l1FLGbWjE9VkZbe2y6pJvCzfFbWsrmDJOMFR+ia8Eu6WFoFS JFstNVitPiFaeU69RHctySRFJCq2wD/STzpypAkOxDgVBsv8iAgFtCpdKbqBU3nlXG/P gQaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rFcPokJ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w2si3476402edu.590.2020.07.27.11.46.33; Mon, 27 Jul 2020 11:48:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rFcPokJ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729728AbgG0Pyz (ORCPT + 99 others); Mon, 27 Jul 2020 11:54:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:42766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728466AbgG0Pyz (ORCPT ); Mon, 27 Jul 2020 11:54:55 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B3082083B; Mon, 27 Jul 2020 15:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595865294; bh=r4gVtL5bEAhWJpndkYkQKV4g6kh85tQmBYzrzdeoQmY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rFcPokJ1hNO2ZAZboOsd6quqJ7MkklxYnGhCWGroq121z/YTSqiAnl5FJEfckXHS9 KYrjHELe2AqYB3FFOyEY3sFaA0NjRlTR0Jz/FAcnQJ7nRW5o9H2rnqaiZbsojZwrKV jugqO6ivP2SosEpZk1LStf5eKRj5TW+oLLgXBVPE= Date: Mon, 27 Jul 2020 08:54:52 -0700 From: Jakub Kicinski To: "Ooi, Joyce" Cc: Thor Thayer , "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Tan Ley Foon , See Chin Liang , Dinh Nguyen , Dalon Westergreen , Richard Cochran Subject: Re: [PATCH v5 08/10] net: eth: altera: add support for ptp and timestamping Message-ID: <20200727085452.412f7031@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200727092157.115937-9-joyce.ooi@intel.com> References: <20200727092157.115937-1-joyce.ooi@intel.com> <20200727092157.115937-9-joyce.ooi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jul 2020 17:21:55 +0800 Ooi, Joyce wrote: > From: Dalon Westergreen > > Add support for the ptp clock used with the tse, and update > the driver to support timestamping when enabled. We also > enable debugfs entries for the ptp clock to allow some user > control and interaction with the ptp clock. > > Cc: Richard Cochran > Signed-off-by: Dalon Westergreen > Signed-off-by: Joyce Ooi W=1 build reveals a warnings, please fix: drivers/net/ethernet/altera/intel_fpga_tod.c:334:55: warning: Using plain integer as NULL pointer