Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200628070152.820311-1-ebiggers@kernel.org> <20200727165000.GH1138@sol.localdomain>
In-Reply-To: <20200727165000.GH1138@sol.localdomain>
From:   Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date:   Tue, 28 Jul 2020 01:59:43 +0900
Message-ID: <CAKFNMo=ZMHP2_14f8g6AxT7WR7Y_0qDXcq7hhqQLsxTgKE5vdw@mail.gmail.com>
Subject: Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-nilfs <linux-nilfs@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Yeah, I sent this to Andrew a little while ago:

  https://lkml.org/lkml/2020/7/27/976

Thanks,
Ryusuke Konishi

On Tue, Jul 28, 2020 at 1:50 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > unlock_new_inode() is only meant to be called after a new inode has
> > already been inserted into the hash table.  But nilfs_new_inode() can
> > call it even before it has inserted the inode, triggering the WARNING in
> > unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
> > inode has the I_NEW flag set, indicating that it's in the table.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Ping.  Ryusuke, any interest in taking this patch?
>
> - Eric