Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAOGTHR7wWaS+CdA9aR-8wWXa-AC47WBuLe5BEg01pFoKwKBpAw@mail.gmail.com>
In-Reply-To: <CAOGTHR7wWaS+CdA9aR-8wWXa-AC47WBuLe5BEg01pFoKwKBpAw@mail.gmail.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon, 27 Jul 2020 11:03:19 -0700
Message-ID: <CAKwvOdnK7+iUyBdBaVTY=5JMK9Fm11PU2sc8ZwYfWs1OYAbeNQ@mail.gmail.com>
Subject: Re: a bug in genksysms/CONFIG_MODVERSIONS w/ __attribute__((foo))?
To:     Rob Simmons <rsimmons514@gmail.com>
Cc:     Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg KH <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Will Deacon <will@kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jul 26, 2020 at 4:31 PM Rob Simmons <rsimmons514@gmail.com> wrote:

You may have forgotten to send a body; but yes genksysms is brittle
and upstream development on it stopped years ago.  Put an attribute
someplace unexpected and the parser will silently fail, making the
modversions hash all zeros, which doesn't protect you from loading a
potentially harmful module with different function signature.  If
you're planning on attending plumbers, I plan to put together a brief
talk on the subject.
-- 
Thanks,
~Nick Desaulniers