Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp5076867pjb; Mon, 27 Jul 2020 12:18:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTDeLEwtsWy479fYuj6NruMzaIxF+BTL8hLNYhwlM9zmwb2Lud/D8xiP9BbQD5MoxiFA6b X-Received: by 2002:a05:6402:1c88:: with SMTP id cy8mr3924927edb.24.1595877517901; Mon, 27 Jul 2020 12:18:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595877517; cv=none; d=google.com; s=arc-20160816; b=alg5D/XvgEjMTWZFsONg/xZMqJtrsX7O9/uP8YFodzNp0VCvVAaAoKxX/MnKzItIf2 VyK72dgEAiX5G0T7vf1JX8iB2yAkCFUYsbtx0eIxgtTvBq7dF7DoLGGr8PWKJoTxeFy7 6Lanc72SN2JhXTOElAGLmN6yoTuvuoQzJYpssZV6PSZz3MZJUZwFtPRIinnpLi2B9sXy zO1592q17m/qiSxLJRdUFKp/7nWpayrIz43nrSgHobXC8eBOD5/cOuu1EyDDbtEUODxu fyQ24lBtY1rqs/vC5z+L6eidpTAf2ErB428+tbjtgoCoAkvumE79+c+s7Fk2umAqIRrc DO8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=PvTgpc7DQYxMLLFo09baj3vxzo+qRVNuYGj2ml+JRDY=; b=aoJciQ9Qg+iWUmPJ5dLdWWM/+H4nBQ6maYpUk9IOsJcc7hfhpRLlgoHNn7EQ//MMMU y3prXLeblgQv2EOl5ObQUpoKFlMOa8+QI7tk985CNMTxYbtp2Pv60HT0sCYDROE7aabj SKwdnVMsSecNgS2mHzpnm2l4+p4JONU2iEW14BnBDLDDMGg/crn0lErzRj3+NXAn/KkD 0pwgQeeziBc0+FPmX/Yzrv+54K2nqlOcYUqa6OYRHxo77bXy0ZsJ6kgxGxbfNzWh1f+C w+M7dct9BwVCMmATPGSNeIv1xoTCo8WZZgHa5jIzj/GiyhBjqQ7rlNS8pHO7zqTLtsHD HomA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e24si6420229edy.323.2020.07.27.12.18.15; Mon, 27 Jul 2020 12:18:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730828AbgG0SjS (ORCPT + 99 others); Mon, 27 Jul 2020 14:39:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728464AbgG0SjS (ORCPT ); Mon, 27 Jul 2020 14:39:18 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2154DC061794; Mon, 27 Jul 2020 11:39:18 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4388A11DB3142; Mon, 27 Jul 2020 11:22:32 -0700 (PDT) Date: Mon, 27 Jul 2020 11:39:16 -0700 (PDT) Message-Id: <20200727.113916.2247175777216104943.davem@davemloft.net> To: gaurav1086@gmail.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net/ipv6] ip6_output: Add ipv6_pinfo null check From: David Miller In-Reply-To: <20200727033810.28883-1-gaurav1086@gmail.com> References: <20200727033810.28883-1-gaurav1086@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Jul 2020 11:22:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gaurav Singh Date: Sun, 26 Jul 2020 23:38:10 -0400 > ipv6_pinfo is initlialized by inet6_sk() which returns NULL. > Hence it can cause segmentation fault. Fix this by adding a > NULL check. Please take your time with such changes and actually look at the compiler output, it will warn that you are adding a new problem. Specifically, the function now fails to return a value at all. But even more important, how is the situation you are fixing possible? Do you have a sample crash? Can you please describe the code paths and conditions that lead to the problem? You must also provide a valid and properly formatted Fixes: tag for bug fixes such as this. Thank you.