Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp5088394pjb; Mon, 27 Jul 2020 12:39:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHs+YRTgq6KwGk6Aw3kgq3APmKuOZSZADLVyrpmxANZ6om4l0HpKh+Eh6VR9tcgtTnHwZL X-Received: by 2002:aa7:d304:: with SMTP id p4mr3848544edq.267.1595878772601; Mon, 27 Jul 2020 12:39:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595878772; cv=none; d=google.com; s=arc-20160816; b=UyTf3i6E6ACsQigPZUL9nOmyhN6QC8VgSRX5Y6MuV+9Tqpaiq7GpW+F3VcOU26HgL8 Gs1TInlDV+2GQrN9MUgquS+raDd8zz6V90ocYecA3PPSgIwJbPnLJzW7IkftThW83ckq rbIwc0e6s4Kgmg0HJozG3/tCccoCqjLBP8NlHxWxyedm8/p+w5w5db8clY7CgjPUUisx nUpOogNzay2eVnJ/sawGO9th/BejbItzwJqNEhMA+dwu/vUhWwqIHiDV6EuyZFQCqbAb j6FCRf979LxzCnRuycZrxyHRFPooNXzEwIAU6aPyl55YW22WbpHDMcv3jv/eYlWXmOeV 0eLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=M9xPKO0rvNEzEhY9QuEzTB/O//d+B18FnmBLxmJSOeA=; b=opu2CUmEjgx/TEu7nxhQTk5aTZXzE0Ty+lJ4jaYsEL6wQOdr2HO5De7p9I6i4BxrJd g/EJY7cKRp3dY8S76t7H7qHvQwOSdUX+RrTkysIy9KB5I0SrFa6J4GSsuZyvD2B2kirc LW/Slh/AIofBKLL0TLZPZ3HwGJ7E8Yx3qoyC5dVJl3FKRVnnfP0Gc8MM9EHhTs2mYHrY PgK1gR2GvLCLILemllkOt0rgHHo1l4tfIwxThy07s8BeyWzxUHNoi5BsnkMazZWw+v82 K8WXegEGzRWNAITksTd4Mpv+YM9XS8Vp9CzCEVjt6pI9Js+qRiwhYsiomgvpJbS6QoVp 6O3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t2si6290360edw.603.2020.07.27.12.39.10; Mon, 27 Jul 2020 12:39:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728587AbgG0Tcf (ORCPT + 99 others); Mon, 27 Jul 2020 15:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbgG0Tcd (ORCPT ); Mon, 27 Jul 2020 15:32:33 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCA58C061794; Mon, 27 Jul 2020 12:32:32 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 89A2812768D9F; Mon, 27 Jul 2020 12:15:46 -0700 (PDT) Date: Mon, 27 Jul 2020 12:32:30 -0700 (PDT) Message-Id: <20200727.123230.568578775098761493.davem@davemloft.net> To: vadym.kochan@plvision.eu Cc: kuba@kernel.org, jiri@mellanox.com, idosch@mellanox.com, andrew@lunn.ch, oleksandr.mazur@plvision.eu, serhiy.boiko@plvision.eu, serhiy.pshyk@plvision.eu, volodymyr.mytnyk@plvision.eu, taras.chornyi@plvision.eu, andrii.savka@plvision.eu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, mickeyr@marvell.com Subject: Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices From: David Miller In-Reply-To: <20200727122242.32337-2-vadym.kochan@plvision.eu> References: <20200727122242.32337-1-vadym.kochan@plvision.eu> <20200727122242.32337-2-vadym.kochan@plvision.eu> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Jul 2020 12:15:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vadym Kochan Date: Mon, 27 Jul 2020 15:22:37 +0300 > + /* called by device driver to pass event up to the higher layer */ > + int (*recv_msg)(struct prestera_device *dev, u8 *msg, size_t size); > + > + /* called by higher layer to send request to the firmware */ > + int (*send_req)(struct prestera_device *dev, u8 *in_msg, > + size_t in_size, u8 *out_msg, size_t out_size, > + unsigned int wait); If you type "msg", "in_msg", and "out_msg" as (void *) you can remove a lot of unnecessary casts in this driver. Thank you.