Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
Subject: Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough
 writes in parallel to origin and cache
From:   John Donnelly <john.p.donnelly@oracle.com>
In-Reply-To: <20200727201700.GJ406581@sasha-vm>
Date:   Mon, 27 Jul 2020 15:38:38 -0500
Cc:     Mike Snitzer <snitzer@redhat.com>, stable@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <6F764B9B-DEE6-4060-9F11-050D2F0999ED@oracle.com>
References: <37c5a615-655d-c106-afd0-54e03f3c0eef@oracle.com>
 <20200727150014.GA27472@redhat.com> <20200727191809.GI406581@sasha-vm>
 <D8DDA535-33D5-4E80-85B3-62A463441B5F@oracle.com>
 <20200727201700.GJ406581@sasha-vm>
To:     Sasha Levin <sashal@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jul 27, 2020, at 3:17 PM, Sasha Levin <sashal@kernel.org> wrote:
>=20
> On Mon, Jul 27, 2020 at 02:38:52PM -0500, John Donnelly wrote:
>>=20
>>=20
>>> On Jul 27, 2020, at 2:18 PM, Sasha Levin <sashal@kernel.org> wrote:
>>>=20
>>> On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitzer wrote:
>>>> This mail needs to be saent to stable@vger.kernel.org (now cc'd).
>>>>=20
>>>> Greg et al: please backport =
2df3bae9a6543e90042291707b8db0cbfbae9ee9
>>>=20
>>> Hm, what's the issue that this patch addresses? It's not clear from =
the
>>> commit message.
>>>=20
>>> --
>>> Thanks,
>>> Sasha
>>=20
>> HI Sasha ,
>>=20
>> In an off-line conversation I had with Mike , he indicated that :
>>=20
>>=20
>> commit 1b17159e52bb31f982f82a6278acd7fab1d3f67b
>> Author: Mike Snitzer <snitzer@redhat.com>
>> Date:   Fri Feb 28 18:00:53 2020 -0500
>>=20
>>  dm bio record: save/restore bi_end_io and bi_integrity
>>=20
>>=20
>> commit 248aa2645aa7fc9175d1107c2593cc90d4af5a4e
>> Author: Mike Snitzer <snitzer@redhat.com>
>> Date:   Fri Feb 28 18:11:53 2020 -0500
>>=20
>>  dm integrity: use dm_bio_record and dm_bio_restore
>>=20
>>=20
>> Were picked up  in  "stable" kernels picked up even though
>> neither was marked for stable@vger.kernel.org
>>=20
>> Adding this missing  commit :
>>=20
>> 2df3bae9a6543e90042291707b8db0cbfbae9ee9
>>=20
>>=20
>> Completes the series
>=20
> Should we just revert those two commits instead if they're not needed?
>=20
> --=20
> Thanks,
> Sasha

  As I stated above:

> Fixes: 705559706d62038b74c5088114c1799cf2c9dce8 (dm bio record:
> save/restore bi_end_io and bi_integrity, version 4.14.188)
>=20
> 70555970 introduced a mkfs.ext4 hang on a LVM device that has been
> modified with lvconvert --cachemode=3Dwritethrough.

  It corrects an issue we discovered in 4.14.188 .    Any other branches =
those two commits have migrated to will likely have the same regression.=20=


I am confident linux-4.14.y will  be better off with it ;-)=20