Date: Thu, 11 May 2006 20:35:40 +0200
From: =?iso-8859-1?Q?J=F6rn?= Engel <joern@wohnheim.fh-wedel.de>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Rik Bobbaers <Rik.Bobbaers@cc.kuleuven.be>, linux-kernel@vger.kernel.org
Subject: Re: fix compiler warning in ip_nat_standalone.c
Message-ID: <20060511183540.GC14232@wohnheim.fh-wedel.de>
References: <200605111729.48871.Rik.Bobbaers@cc.kuleuven.be> <20060511155537.GF1104@wohnheim.fh-wedel.de> <20060511161846.GM27946@ftp.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20060511161846.GM27946@ftp.linux.org.uk>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 911
Lines: 25

On Thu, 11 May 2006 17:18:46 +0100, Al Viro wrote:
> On Thu, May 11, 2006 at 05:55:37PM +0200, J?rn Engel wrote:
> > 
> > You cannot fix a compiler warning!
> > 
> > Either the code is wrong or it is right.  A compiler warning can
> > indicate that code is wrong, or it is a false positive.  If the code
> > is wrong, fix the _code_.
> 
> Which is what the patch does, AFAICS.  What's the problem in this case?

See subject.  I didn't object to the patch, that looked fine to me.
But the general idea that a warning can be fixed always hits a loose
nerve in my brain.  Maybe I'm a bit silly in this respect.

J?rn

-- 
When in doubt, use brute force.
-- Ken Thompson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/