Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200727134914.312934924@linuxfoundation.org> <20200727134917.124943291@linuxfoundation.org>
 <20200727212933.pkt6kgescdz7akht@duo.ucw.cz> <20200727220112.GV1665100@dtor-ws>
In-Reply-To: <20200727220112.GV1665100@dtor-ws>
From:   "dbasehore ." <dbasehore@chromium.org>
Date:   Mon, 27 Jul 2020 15:18:06 -0700
Message-ID: <CAGAzgsrTBm0UWM5QwxzePRrpz2xOUsJ4cuyj28q=ik++OQ-dkw@mail.gmail.com>
Subject: Re: [PATCH 4.19 54/86] Input: elan_i2c - only increment wakeup count
 on touch
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 27, 2020 at 3:01 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Mon, Jul 27, 2020 at 11:29:33PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > From: Derek Basehore <dbasehore@chromium.org>
> > >
> > > [ Upstream commit 966334dfc472bdfa67bed864842943b19755d192 ]
> > >
> > > This moves the wakeup increment for elan devices to the touch report.
> > > This prevents the drivers from incorrectly reporting a wakeup when the
> > > resume callback resets then device, which causes an interrupt to
> > > occur.
> >
> > Contrary to the changelog, this does not move anything... unlike
> > mainline, it simply adds two pm_wakeup_events.
> >
> > It may still be correct, but maybe someone wants to double-check?
>
> Good catch, I believe the backport is busted.

I don't believe it will break anything, but the backport isn't needed
in 4.19 since "Input: elan_i2c - increment wakeup count if wake
source" wasn't merged into 4.19. It's probably best to drop the
backport.

>
> Thanks.
>
> --
> Dmitry