Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200727184506.2279656-1-guro@fb.com> <20200727184506.2279656-13-guro@fb.com>
In-Reply-To: <20200727184506.2279656-13-guro@fb.com>
From:   Song Liu <song@kernel.org>
Date:   Mon, 27 Jul 2020 17:01:23 -0700
Message-ID: <CAPhsuW7Bk3Xbu2bcb0aJw_McMWXnUL90jj1qQK1a_e126GpESA@mail.gmail.com>
Subject: Re: [PATCH bpf-next v2 12/35] bpf: refine memcg-based memory
 accounting for xskmap maps
To:     Roman Gushchin <guro@fb.com>
Cc:     bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Kernel Team <kernel-team@fb.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 27, 2020 at 12:25 PM Roman Gushchin <guro@fb.com> wrote:
>
> Extend xskmap memory accounting to include the memory taken by
> the xsk_map_node structure.
>
> Signed-off-by: Roman Gushchin <guro@fb.com>

Acked-by: Song Liu <songliubraving@fb.com>

> ---
>  net/xdp/xskmap.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/xdp/xskmap.c b/net/xdp/xskmap.c
> index 8367adbbe9df..e574b22defe5 100644
> --- a/net/xdp/xskmap.c
> +++ b/net/xdp/xskmap.c
> @@ -28,7 +28,8 @@ static struct xsk_map_node *xsk_map_node_alloc(struct xsk_map *map,
>         struct xsk_map_node *node;
>         int err;
>
> -       node = kzalloc(sizeof(*node), GFP_ATOMIC | __GFP_NOWARN);
> +       node = kzalloc(sizeof(*node),
> +                      GFP_ATOMIC | __GFP_NOWARN | __GFP_ACCOUNT);
>         if (!node)
>                 return ERR_PTR(-ENOMEM);
>
> --
> 2.26.2
>