Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Jul 2020 02:19:37 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Peng Fan <fanpeng@loongson.cn>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: Re: [PATCH] power: supply: rt5033_battery: Fix error code in
 rt5033_battery_probe()
Message-ID: <20200728001937.vtvneczrskc6cs4u@earth.universe>
References: <1593680332-31884-1-git-send-email-fanpeng@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7od7w7hhl7sikvqk"
Content-Disposition: inline
In-Reply-To: <1593680332-31884-1-git-send-email-fanpeng@loongson.cn>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--7od7w7hhl7sikvqk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Jul 02, 2020 at 04:58:52PM +0800, Peng Fan wrote:
> In the function rt5033_battery_probe(), it should return -ENOMEM
> instead of -EINVAL when call function devm_kzalloc() failed.
>=20
> Signed-off-by: Peng Fan <fanpeng@loongson.cn>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/rt5033_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply=
/rt5033_battery.c
> index d8667a9..f330452 100644
> --- a/drivers/power/supply/rt5033_battery.c
> +++ b/drivers/power/supply/rt5033_battery.c
> @@ -125,7 +125,7 @@ static int rt5033_battery_probe(struct i2c_client *cl=
ient,
> =20
>  	battery =3D devm_kzalloc(&client->dev, sizeof(*battery), GFP_KERNEL);
>  	if (!battery)
> -		return -EINVAL;
> +		return -ENOMEM;
> =20
>  	battery->client =3D client;
>  	battery->regmap =3D devm_regmap_init_i2c(client,
> --=20
> 2.1.0
>=20

--7od7w7hhl7sikvqk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl8fbxkACgkQ2O7X88g7
+pog2A/8DVU5QYgx87Or/U3pWkw+/hgTRmm5UVuocenyM22SgCXnd+SHVLLpF12P
NinS8uhYlufo7HRznagwQr1t2uy2AT8IpQ13VpwjcidHZYbCqudJtUNL9gJ0VYVO
OKmwlQeROyXnjqiM5dKA48TXcFvXFmzsg9vOphwsN+uY0DsoZOimHmGHc2XRZ+dc
x3HmlBNX9z8C+y1JoiP/b7H8oXXUhxXnZZ0Ogs04jmlE38CSClPwAhVvcd8umqyZ
sZgnGlaG2uCV8/ZvSvstBzEJAwaP23VLEZoqccs+9v3nI97JVml0oAP1U8yq7Xah
XF1h8bxRsxzxZ2cq1htGlXy7TlwNmHqgBiskM+AyuHOOViKyGJR5ug/RCUEGc5y+
JT39Yk6rhrowEIZlsAaJGOWGeuXAHO1UwE1bg6nZDazRPZ9GExk9bmu7vrhnLODS
CHnnaMh2oK+KW2oVenfm1y7Du1GAa3jiDCLTXXFV6ZACQu9jh7N55BzdfdnvmInR
NzHV9+55pcbk9U/blUGn4A4LTzBdptv6z/Y42URoghn2ks4dxNlhtwKCWWIVEm3p
uc24pzQJJp4YpexNlZr+giQ/jD6muqgUdS5lml8rPTw7Dui5Ya9Z4Q8YHNfhnzit
ZwZfH8dlK7Z8uoKco4TeafPi91n25hyPgx//TgqyhMNvBCYaRvE=
=xY1+
-----END PGP SIGNATURE-----

--7od7w7hhl7sikvqk--