Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C69BCC433C9
Date:   Tue, 28 Jul 2020 08:29:22 +0800
From:   Tingwei Zhang <tingweiz@codeaurora.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Tingwei Zhang <tingwei@codeaurora.org>,
        Ingo Molnar <mingo@redhat.com>, tsoni@codeaurora.org,
        Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
        Mao Jinlong <jinlmao@codeaurora.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] tracing: add flag to control different traces
Message-ID: <20200728002922.GB10290@codeaurora.org>
References: <20200726025931.30510-1-tingwei@codeaurora.org>
 <20200726025931.30510-3-tingwei@codeaurora.org>
 <20200727144550.7aa40c61@oasis.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200727144550.7aa40c61@oasis.local.home>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steve,
On Tue, Jul 28, 2020 at 02:45:50AM +0800, Steven Rostedt wrote:
> On Sun, 26 Jul 2020 10:59:27 +0800
> Tingwei Zhang <tingwei@codeaurora.org> wrote:
> 
> 
> > diff --git a/include/linux/trace.h b/include/linux/trace.h
> > index 7fd86d3c691f..d2fdf9be84b5 100644
> > --- a/include/linux/trace.h
> > +++ b/include/linux/trace.h
> > @@ -3,6 +3,9 @@
> >  #define _LINUX_TRACE_H
> >  
> >  #ifdef CONFIG_TRACING
> > +
> > +#define TRACE_EXPORT_FUNCTION	BIT_ULL(0)
> 
> All the flags variables below are defined as "int". Why the BIT_ULL()?
> BIT(0) should work just fine. The ULL makes one think these flags will
> be used for unsigned long variables, which it is not.
> 

That's my mistake.  Thanks for point that out. I'll fix it in next
revision.

> -- Steve
> 
> 
> > +
> 
> >  struct trace_export {
> >  	struct trace_export __rcu	*next;
> >  	void (*write)(struct trace_export *, const void *, unsigned int);
> > +	int flags;
> >  };
> >  
> >  int register_ftrace_export(struct trace_export *export);
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index bb62269724d5..8f1e66831e9e 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -2747,33 +2747,37 @@ trace_buffer_unlock_commit_nostack(struct
> trace_buffer *buffer,
> >  
> >  static void
> >  trace_process_export(struct trace_export *export,
> > -	       struct ring_buffer_event *event)
> > +	       struct ring_buffer_event *event, int flag)
> >  {
> >  	struct trace_entry *entry;
> >  	unsigned int size = 0;
> >  
> > -	entry = ring_buffer_event_data(event);
> > -	size = ring_buffer_event_length(event);
> > -	export->write(export, entry, size);
> > +	if (export->flags & flag) {
> > +		entry = ring_buffer_event_data(event);
> > +		size = ring_buffer_event_length(event);
> > +		export->write(export, entry, size);
> > +	}
> >  }