Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1D2CEC433C9
Date:   Tue, 28 Jul 2020 08:28:23 +0800
From:   Tingwei Zhang <tingweiz@codeaurora.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Tingwei Zhang <tingwei@codeaurora.org>,
        Ingo Molnar <mingo@redhat.com>, tsoni@codeaurora.org,
        Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
        Mao Jinlong <jinlmao@codeaurora.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] stm class: ftrace: use different channel
 accroding to CPU
Message-ID: <20200728002823.GA10290@codeaurora.org>
References: <20200726025931.30510-1-tingwei@codeaurora.org>
 <20200726025931.30510-7-tingwei@codeaurora.org>
 <20200727150812.3051fa7d@oasis.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200727150812.3051fa7d@oasis.local.home>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steve,
On Tue, Jul 28, 2020 at 03:08:12AM +0800, Steven Rostedt wrote:
> On Sun, 26 Jul 2020 10:59:31 +0800
> Tingwei Zhang <tingwei@codeaurora.org> wrote:
> 
> > --- a/drivers/hwtracing/stm/ftrace.c
> > +++ b/drivers/hwtracing/stm/ftrace.c
> > @@ -37,8 +37,9 @@ static void notrace
> >  stm_ftrace_write(struct trace_export *export, const void *buf, unsigned
> int len)
> >  {
> >  	struct stm_ftrace *stm = container_of(export, struct stm_ftrace,
> ftrace);
> > +	unsigned int cpu = smp_processor_id();
> 
> Probably should add a comment to the above stating that this is called
> from the tracing system with preemption disabled.
> 

Good point. I'll add that comment in next revision.

Thanks,
Tingwei

> Other than my two comments:
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> -- Steve
> 
> 
> >  
> > -	stm_source_write(&stm->data, STM_FTRACE_CHAN, buf, len);
> > +	stm_source_write(&stm->data, STM_FTRACE_CHAN + cpu, buf, len);
> >  }
> >  
> >  static int stm_ftrace_link(struct stm_source_data *data)