Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp122348ybg; Mon, 27 Jul 2020 17:39:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYVVdo7HTRYEoJIQbG0YGGMwitY7WnfS/wC1brFYfZXsWLm68vJh88EwRMb3OrrmuvZ2ZL X-Received: by 2002:a17:906:1403:: with SMTP id p3mr22890534ejc.106.1595896772438; Mon, 27 Jul 2020 17:39:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595896772; cv=none; d=google.com; s=arc-20160816; b=QLvNalwfeaW6YkLc+4+h6A8mvBfSMlhNwqHjynatKSrMqO+cgt8yiP4DKc1ZjayvKI CYFiDaI6BO7dEVprzhfIMI52rJQs8OLFqmvRFxEr/WifipEjukQIFBcakn0FxYAoN7Wm QyJ8pgkgTHhw8m0Y2wqrUUOV+r3iEvHuMLU4jtsvWZVCiBhJoHBILNbbPUDsAKVpflTB JdvLDKTxiTfMgWs04m1wbUVOTxgzNHuTaZQtauWRh/ybMp+iBAF8iIVxblGCO36RhXoQ K1D5z40aZEB9LgisDcf4q6QguqLOb27zMYr3CBPSOVX4VQoZNkAk3+H04tv9Nh5iyDtd 6PgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=QGPyzJMYpm5rNGiy2RCvBHSHbzxJHl4M+7tBgxvoviM=; b=vUyE0cpcEEvakJrAMR0j/7+xzUqtKAV/8V09viErH+35nxhSSNmra3zM36bOMQCdx3 O4vEkaVMfZgtZ9DL9IJ+NNGXmbWkTMXlpDl3OZJ4+7nphVZOmEr0H2yyuJicgEbvpy5W zQrkEKtU+cE1DuWooAOT6T9oy0zoJ7h63IsG6/ekOFx/LRTg0QtavWKAtACi8sA+rkOx ffXJL+tkl8pYBFq5ZRcT964GmaAbe5a4KJJGtfJMyceiTvIjgI24rtqTffRDxxW+M1HB VFeP6lwK+xnjCTZzzYcKclwKu68F/NKf0KwzoENLcylx/lb8SCJqSoKftBmAa+QF3yCw GAgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si6420137eju.177.2020.07.27.17.39.09; Mon, 27 Jul 2020 17:39:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbgG1Agu (ORCPT + 99 others); Mon, 27 Jul 2020 20:36:50 -0400 Received: from mga07.intel.com ([134.134.136.100]:44770 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726091AbgG1Agu (ORCPT ); Mon, 27 Jul 2020 20:36:50 -0400 IronPort-SDR: rHJ/QWobR8Dqz6I4cAx93LL6ZpH35o2M9ShTWNClKNxrNYkSsdIBaDFIJaOXZdpCDfYlq7ya5H KD4mnxViSE7w== X-IronPort-AV: E=McAfee;i="6000,8403,9695"; a="215662507" X-IronPort-AV: E=Sophos;i="5.75,404,1589266800"; d="scan'208";a="215662507" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2020 17:36:49 -0700 IronPort-SDR: IxH+tGoVKPdytVZIaU6gWFsjUhs5XZzGizmV66F0YuHxiwkgVCwX7Pahf7wg3CFqjR5XAVXaPw GjbkN9f3WWIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,404,1589266800"; d="scan'208";a="329864825" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by orsmga007.jf.intel.com with ESMTP; 27 Jul 2020 17:36:49 -0700 Date: Mon, 27 Jul 2020 17:36:31 -0700 From: Ricardo Neri To: peterz@infradead.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , x86@kernel.org, Dave Hansen , Tony Luck , Cathy Zhang , Fenghua Yu , "H. Peter Anvin" , Kyung Min Park , "Ravi V. Shankar" , Sean Christopherson , linux-kernel@vger.kernel.org, Ricardo Neri , Dave Hansen , linux-edac@vger.kernel.org Subject: Re: [PATCH 4/4] x86/cpu: Use SERIALIZE in sync_core() when available Message-ID: <20200728003631.GB23421@ranerica-svr.sc.intel.com> References: <20200727043132.15082-1-ricardo.neri-calderon@linux.intel.com> <20200727043132.15082-5-ricardo.neri-calderon@linux.intel.com> <20200727082003.GD119549@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727082003.GD119549@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 10:20:03AM +0200, peterz@infradead.org wrote: > On Sun, Jul 26, 2020 at 09:31:32PM -0700, Ricardo Neri wrote: > > +static inline void serialize(void) > > +{ > > + asm volatile(".byte 0xf, 0x1, 0xe8"); > > +} > > Can we pretty please have a comment with the binutils version that has > the mnomic? Such that when we increase the required binutils version we > can grep for this. This is supported since binutils 2.35[1]. I'll add a comment with the clarification. Thanks and BR, Ricardo [1]. https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob_plain;f=gas/NEWS;;hb=refs/tags/binutils-2_35