Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp132142ybg; Mon, 27 Jul 2020 18:00:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXGIb9Lax5XVDXQC6s12Dqc11mFk//4f4XYoauBxIzq/hpwdvEQ+Q6KyUJWoeg9Kz6fn/D X-Received: by 2002:aa7:dd14:: with SMTP id i20mr24704637edv.41.1595898052943; Mon, 27 Jul 2020 18:00:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595898052; cv=none; d=google.com; s=arc-20160816; b=LlyAyS/eKRqgZA55brBU7yt7ASlUjB1lqBaiAaIPDXB+vomuQPRZYPqDkh8GckI2VK cgNQFfOa4XjKEGV6DNBz39TtNUE5fG+INR7i7bC4P042X1hgl+I7sptVlkjUeY/f3sjH eny5+btQfFu+wsrtA/dYkRBc5awiwulQc+BL1Q4dNd1nKhNa4EsFXILJspBOiwxijn56 LJUCJyghgdb16UzUdRPLxlw4g0Wp54vVq1iMvQ7p9X192pb+UQjcOgcAI7cygOBx0S/K 0C/F0AjQ9DGmIhvLb5XIW93vKv9p6PcEFIsl9RQtjIQuf3TUz8kMylx9GCvPrM5A7CB0 BY3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=M7kikyJR3zyQSalklKBdt8vBwhRvFx+81Goekf18aG4=; b=nUDeI6CeCl1suHy8JwtrpwCb7xj0fCAaCkrVmCxB/7JfG+bK+WKQqoyzcvEVg5k4j5 esF9n/3j+8dtvHfOrsmr9XGbSPKouxD+6R0aHW3sAW+3QvAI+4tp2LnlBWNd3tFOprNs 2dpGVpear/KlK8NpzbyejYtFRXI4tRqXag3gb3hpCiHQTeolu+Iq/LSP2hGKjLB9mYy2 R+RvrFKFYKP6HGNh7tKnMHYJbyR6q7A6UXyrai2UyJTiQUal3ZYeHyyNgYNgoogVft1Y vgSMq5j/ynXRNQoMN4Sm+YXFvCQmVfvxTFxK5N7YfSjKE5xPIw1HLnksbBhl+MwUeESn ehdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CgwDMWeD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si1397558eds.470.2020.07.27.18.00.30; Mon, 27 Jul 2020 18:00:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CgwDMWeD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbgG1A7o (ORCPT + 99 others); Mon, 27 Jul 2020 20:59:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:56638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgG1A7n (ORCPT ); Mon, 27 Jul 2020 20:59:43 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 043ED20809; Tue, 28 Jul 2020 00:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595897983; bh=u8nl1DFIWFG6UKSluVniywWOMGkPGO7/1nDNjF8VG6g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CgwDMWeDpj55eSWPeS/OCfghvavliIMPpgAJFN7VccKYuAF3CRbPQEVbounLQHLPC rniC1IyXNMv0UAdkiQ3tKRnLayqk2uwIwVLfT59WP8jrfakqF6i5kFW1qhrKVePkXR CsDMRGjCvH+OtAqdlnzW5ssAnn5iGKbbx0xfB/H0= Date: Mon, 27 Jul 2020 17:59:41 -0700 From: Jakub Kicinski To: Moshe Shemesh Cc: "David S. Miller" , Jiri Pirko , Vasundhara Volam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next RFC 10/13] net/mlx5: Add devlink param enable_remote_dev_reset support Message-ID: <20200727175941.05550c92@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1595847753-2234-11-git-send-email-moshe@mellanox.com> References: <1595847753-2234-1-git-send-email-moshe@mellanox.com> <1595847753-2234-11-git-send-email-moshe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jul 2020 14:02:30 +0300 Moshe Shemesh wrote: > static void mlx5_sync_reset_request_event(struct work_struct *work) > { > struct mlx5_fw_reset *fw_reset = container_of(work, struct mlx5_fw_reset, > reset_request_work); > struct mlx5_core_dev *dev = fw_reset->dev; > + int err; > > + if (test_bit(MLX5_HEALTH_RESET_FLAGS_NACK_RESET_REQUEST, &dev->priv.health.reset_flags)) { > + err = mlx5_fw_set_reset_sync_nack(dev); > + mlx5_core_warn(dev, "PCI Sync FW Update Reset Nack %s", > + err ? "Failed" : "Sent"); > + return; > + } What if the NACK fails? Does the reset still proceed? > mlx5_health_set_reset_requested_mode(dev); > mlx5_reload_health_poll_timer(dev); > if (mlx5_fw_set_reset_sync_ack(dev))