Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp143822ybg; Mon, 27 Jul 2020 18:23:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyV3c+A1PHTRSqapFiQAGdDwgr1FngCDMT6MyE6jFfGy1xGRG23JJpZSKVGYa4omPm8+rnJ X-Received: by 2002:a50:8749:: with SMTP id 9mr23985865edv.80.1595899387329; Mon, 27 Jul 2020 18:23:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595899387; cv=none; d=google.com; s=arc-20160816; b=dHTuhK7LFNqVTLi0N62UdYWmeECHHJtfX1AjFM5a4eWAD08ZFX2/MiIf2Z+xEyR/12 /Egi1AWW4/ivNS7M7k+UH7fwjD4Z1lmkOuUTR5/hTq4medLXL/r5WJR9sseaGxsZqbq4 lSk7hrE9VrvPtiUXx0kFQHCPU9hQSRAMu7xDYfEam9WyiPQTkmJHONCyqCWXlF1yz1TF jH8YB4d1zL1MXbqRIw9KrJwBnV3bhdVt+lx86ZUG5P55o315k0GeYJ/xWga4eWpnR+dQ 02pTTRhhNUIPyohEZR8B4YLyOZ3A0s+dLTEgv1GbdZBDYhQU6Fn/AUZQasvx9kTwsU/9 mDxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=VjPgbBotx2j2mpmZm5DhzzZAaPi7egObI23Ux2zgilU=; b=rzpeDP0gQCujtqRq35HoedUcWYtxlr19FzaS/FZSl1B4Cz/jpw6iNKpMAgIlp7AkIu GmmOlYLKW+ajLk90AMkY8JxssovYddR6mbIpzhUP8sX/p1ohDJWDRcS0aZ0LXpXc1Kg7 ZjcO7smn9rE1PBlGiiV1GDKgXEc4fb2BA3EF0PVDw48L8lDVywBwUXlcU/GxT1Wk2Fxw gSDSynlARp9Yfjn5ywn8m6fXAFL/logZX1Wne6Y2d04phE9QlzDtpLllRDjvi8XooLzm 9EXOnlKYFpiSQnve/Dp+JYSA4D4H/TrujliRDMOe1jd4lVRILxefMaUYi/vKpb2bSLBY FWiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NEvUTzyi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c26si6595542edy.599.2020.07.27.18.22.44; Mon, 27 Jul 2020 18:23:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NEvUTzyi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726357AbgG1BWH (ORCPT + 99 others); Mon, 27 Jul 2020 21:22:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:33760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgG1BWH (ORCPT ); Mon, 27 Jul 2020 21:22:07 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8514720829; Tue, 28 Jul 2020 01:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595899326; bh=VjPgbBotx2j2mpmZm5DhzzZAaPi7egObI23Ux2zgilU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=NEvUTzyiBNiWr+fWR/YT23YZciibr7s6ygXP081pqi4Jl9H4BN9P/xjJzE9dzy+gD iA7kVxRkvXA63QQP4iwDSCOIYLAkotZP5mza+P4ijXczOV7qTdX2/JYTHv+vqEt1De FyhA9/kNgm62R5JFBBEafghvAExO2UzuYRdYyos0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200713032143.21362-1-vulab@iscas.ac.cn> References: <20200713032143.21362-1-vulab@iscas.ac.cn> Subject: Re: [PATCH] clk: clk-atlas6: fix return value check in atlas6_clk_init() From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Xu Wang To: Xu Wang , baohua@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com Date: Mon, 27 Jul 2020 18:22:05 -0700 Message-ID: <159589932546.1360974.12932267268128581186@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Xu Wang (2020-07-12 20:21:43) > In case of error, the function clk_register() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). >=20 > Signed-off-by: Xu Wang > --- Applied to clk-next