Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com>
 <1594983811-25908-2-git-send-email-gene.chen.richtek@gmail.com> <20200727110821.GH1850026@dell>
In-Reply-To: <20200727110821.GH1850026@dell>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Tue, 28 Jul 2020 02:16:15 +0800
Message-ID: <CAE+NS34FexE-LwbzkOLepKytKCbKm3RowPQKqROR_a6wCrVLLA@mail.gmail.com>
Subject: Re: [PATCH v2 1/9] mfd: mt6360: Rearrange include file
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        Gene Chen <gene_chen@richtek.com>, benjamin.chao@mediatek.com,
        shufan_lee@richtek.com, cy_huang@richtek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Lee Jones <lee.jones@linaro.org> =E6=96=BC 2020=E5=B9=B47=E6=9C=8827=E6=97=
=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=887:08=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Fri, 17 Jul 2020, Gene Chen wrote:
>
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Rearrange include file without sorting by alphabet.
>
> Why are you making this change?
>

Personal coding style references from upstream code.
I can discard this change if it doesn't make sense.

> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> >  drivers/mfd/mt6360-core.c | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> > index e9cacc2..df4506f 100644
> > --- a/drivers/mfd/mt6360-core.c
> > +++ b/drivers/mfd/mt6360-core.c
> > @@ -5,15 +5,14 @@
> >   * Author: Gene Chen <gene_chen@richtek.com>
> >   */
> >
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> >  #include <linux/i2c.h>
> > -#include <linux/init.h>
> > +#include <linux/crc8.h>
> > +#include <linux/slab.h>
> > +#include <linux/regmap.h>
> >  #include <linux/interrupt.h>
> > -#include <linux/kernel.h>
> >  #include <linux/mfd/core.h>
> > -#include <linux/module.h>
> > -#include <linux/of_irq.h>
> > -#include <linux/of_platform.h>
> > -#include <linux/version.h>
> >
> >  #include <linux/mfd/mt6360.h>
> >
>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Senior Technical Lead - Developer Services
> Linaro.org =E2=94=82 Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog