Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200727232346.0106c375@canb.auug.org.au> <e342e8ce-db29-1603-3fd9-40792a783296@infradead.org>
In-Reply-To: <e342e8ce-db29-1603-3fd9-40792a783296@infradead.org>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 27 Jul 2020 22:48:05 -0700
Message-ID: <CAEf4BzYD-PiA2cDvD5qRv7hHZ_GTDdKqAm1jfg2ZWBWM_3YO5w@mail.gmail.com>
Subject: Re: linux-next: Tree for Jul 27 (kernel/bpf/syscall.o)
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 27, 2020 at 11:58 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 7/27/20 6:23 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20200724:
> >
>
> on i386:
> when CONFIG_XPS is not set/enabled:
>
> ld: kernel/bpf/syscall.o: in function `__do_sys_bpf':
> syscall.c:(.text+0x4482): undefined reference to `bpf_xdp_link_attach'
>

I can't repro this on x86-64 with CONFIG_XPS unset. Do you mind
sharing the exact config you've used?

I see that kernel/bpf/syscall.c doesn't include linux/netdevice.h
directly, so something must be preventing netdevice.h to eventually
get to bpf/syscall.c, but instead of guessing on the fix, I'd like to
repro it first. Thanks!


>
> --
> ~Randy
> Reported-by: Randy Dunlap <rdunlap@infradead.org>