Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 1W1hzCmiN9VvA84NYArEssp07tnIXE32zlilu5/KtH1udAIYxgswP9bF/UN29C4FraW9sapHzO
 D2btav/Vw14A==
From:   SeongJae Park <sjpark@amazon.com>
To:     Joe Perches <joe@perches.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        SeongJae Park <sjpark@amazon.com>,
        =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>,
        SeongJae Park <sj38.park@gmail.com>,
        <linux-kernel@vger.kernel.org>, <apw@canonical.com>,
        <colin.king@canonical.com>, <jslaby@suse.cz>, <pavel@ucw.cz>,
        SeongJae Park <sjpark@amazon.de>, <dan.j.williams@intel.com>,
        <corbet@lwn.net>, <gregkh@linuxfoundation.org>, <mishi@linux.com>,
        <skhan@linuxfoundation.org>
Subject: Re: checkpatch: support deprecated terms checking
Date:   Tue, 28 Jul 2020 08:22:49 +0200
Message-ID: <20200728062249.25469-1-sjpark@amazon.com>
In-Reply-To: <7f07e16c47c7dcb35685cddbb3a740e4698258fc.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 27 Jul 2020 13:49:00 -0700 Joe Perches <joe@perches.com> wrote:

> On Mon, 2020-07-27 at 13:44 -0700, Andrew Morton wrote:
> > On Mon, 27 Jul 2020 08:54:41 +0200 SeongJae Park <sjpark@amazon.com> wrote:
> > 
> > > > > > Unfortunately, the inexperienced _do_ in fact run
> > > > > > checkpatch on files and submit inappropriate patches.
> > 
> > I don't think I really agree with the "new code only" guideline (where
> > did this come from, anyway?).  10 years from now any remaining pre-2020
> > terms will look exceedingly archaic and will get converted at some
> > point.
> > 
> > Wouldn't be longterm realistic to just bite the bullet now and add these
> > conversions to the various todo lists?
> 
> I don't think so.
> 
> There's no exclusion list for existing uses
> written to external specification.
> 
> It's just emitting effectively noisy warnings
> on things that should not be changed.
> 

Just noticed that this patchset and the followup[1] for sync with inclusive
terms commit[2] are dropped from -mm tree.  I admit it could generate some
false positive warnings, though my followup patch[3] makes the message noisy
but gives clear references.

I still believe it's better to provide the messages, but I also know people
could think differently.  After all, the biggest part of the initial goal of
this patches is already made by the inclusive terms commit[2].  So, I would
respect the decision.

[1] https://lore.kernel.org/lkml/20200713071912.24432-1-sjpark@amazon.com/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/process/coding-style.rst?id=a5f526ecb075a08c4a082355020166c7fe13ae27
[3] https://lore.kernel.org/lkml/20200726180748.29924-1-sj38.park@gmail.com/


Thanks,
SeongJae Park