Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [v2 4/4] clk: x86: Support RV architecture
To:     Stephen Boyd <sboyd@kernel.org>, akshu.agrawal@amd.com
Cc:     Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200720050500.23357-1-akshu.agrawal@amd.com>
 <20200720050500.23357-5-akshu.agrawal@amd.com>
 <159531874995.3847286.4010361856630371541@swboyd.mtv.corp.google.com>
From:   "Agrawal, Akshu" <aagrawal2@amd.com>
Message-ID: <807b3eec-cc11-dbbf-7d35-0086df12f52b@amd.com>
Date:   Tue, 28 Jul 2020 12:06:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <159531874995.3847286.4010361856630371541@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.105] (122.171.179.172) by MA1PR01CA0071.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21 via Frontend Transport; Tue, 28 Jul 2020 06:37:04 +0000
X-Originating-IP: [122.171.179.172]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 588a44cf-e899-486a-6cc6-08d832c0a543
X-MS-TrafficTypeDiagnostic: DM5PR12MB1899:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR12MB18995FEF2F798F1F4D284808F8730@DM5PR12MB1899.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fVWvivYuCrnvkgm/FmSsG1/nhfz9/GcZoqXkFLcPIsmMlGG1BXjzC+IoG712ucL/HW2D0W1CG3GMsh4s5+k3aC/VbEj0e10fO2xsCFn0dz2IBC/DvqT3uQPSsbVRkJSRnF2Zphl0AAUkC0P3kvZX1vvzH/OpNUcH2qVPJzruRcd9aSUBN6Fdnx5pN3hk5wPMPoeUPubP6hRa+wMfaf9xEw/WgSxZt6PrZwnaEZmmYSEXkFSpKwzO5KShZrCUuAal2u1rqwZ/9KjjoG7bocUXhp505a4WkgNwKOICD3K/s4D0ZVnV9D6FRHmww8gt+HIgOekV8IXGHMpThaLP2Aa1LOFFMJTmrmoUHB6BuK3o26jhD/4x2y9iZf/aWIiYuEdY
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1201MB0188.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(5660300002)(31696002)(31686004)(66556008)(66476007)(66946007)(4744005)(53546011)(52116002)(26005)(2616005)(478600001)(2906002)(6666004)(8936002)(4326008)(8676002)(6636002)(16526019)(16576012)(316002)(956004)(186003)(36756003)(6486002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: HMdjg96KHevKKnbk8d0kwFFx1g8gblN5yZHnSC94xdEArzjhXgRAYgkVz03czsfUsvv9q88rkkgRECWVyIZO8KYJH+0fztyZohu11GvblKYqdd996bXvkQ5lwwysGMPPOz374tPYWRmC1q1D8POOh4CnJzpVngviCdPy/0R4cEIO5EUIJoU2X/pBuusgivhA7aWGXQAc/ooAgNjTMNAihsbV2gj+yyB+9/KszoSpuLFIOJ/Ckgy5Ot3S5oBlVOfIrnt4wq0MJMX1w7/fDglj9/gdIAK1BrZbbqpIJ4nrkBLnESGXlAgJoofa/tQDUKIG7xFeL7VodxTiSgur9fg3WOPIo7OOuaZbKb6qjGn8kaTXElH6dDqBAMRR/IRdS8glWUVL9mmBm9LTE1EAoACn0qq6SPlHm5vfw3vFWC1GHTNi5+5qVhfvwGtlRYEQ+4Vdm5vqyVNYHAGrStHAejoM6NxlbyRSy0U/PAnBZBUGQBk39qUqo873zCGFRc/Paq4j
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 588a44cf-e899-486a-6cc6-08d832c0a543
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1201MB0188.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2020 06:37:06.2503
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 42r5Up0LiFnGF+m8hqKyeeZmh4Pa/6vAiOtvfN9RocbRNnFCTnN4chNlSGi5WBIJevaDLYyNSAM/DtrGQrxf7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1899
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/21/2020 1:35 PM, Stephen Boyd wrote:
> Quoting Akshu Agrawal (2020-07-19 22:04:59)
>> diff --git a/drivers/clk/x86/clk-fch.c b/drivers/clk/x86/clk-fch.c
>> index b252f0cf0628..d68bca7b213f 100644
>> --- a/drivers/clk/x86/clk-fch.c
>> +++ b/drivers/clk/x86/clk-fch.c
> [...]
>>   
>>   static int fch_clk_remove(struct platform_device *pdev)
>>   {
>> -       int i;
>> +       int i, clks;
>> +       struct fch_clk_data *fch_data;
>>   
>> -       for (i = 0; i < ST_MAX_CLKS; i++)
>> +       fch_data = dev_get_platdata(&pdev->dev);
>> +
>> +       clks = (!fch_data->is_rv) ? ST_MAX_CLKS : RV_MAX_CLKS;
> Useless parenthesis and negation, just write:
>
> 	num = fch_data->is_rv ? RV_MAX_CLKS : ST_MAX_CLKS;

Sure, including in the next patch set.

Thanks,

Akshu

>
>> +
>> +       for (i = 0; i < clks; i++)
>>                  clk_hw_unregister(hws[i]);
>> +
>>          return 0;
>>   }
>>