Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@amd.com>
To:     Mark Brown <broonie@kernel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
CC:     "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>, Arnd Bergmann <arnd@arndb.de>,
        open list <linux-kernel@vger.kernel.org>,
        YueHaibing <yuehaibing@huawei.com>,
        Takashi Iwai <tiwai@suse.com>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Agrawal, Akshu" <Akshu.Agrawal@amd.com>
Subject: RE: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682
Thread-Topic: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682
Thread-Index: AQHWZCbm+DcS7P+G90ayphwZlFTok6kbjasAgAAKsoCAAPTPkA==
Date:   Tue, 28 Jul 2020 06:59:50 +0000
Message-ID: <DM5PR1201MB01393D93D69F1552408BFE79E7730@DM5PR1201MB0139.namprd12.prod.outlook.com>
References: <20200727145840.25142-1-Vishnuvardhanrao.Ravulapati@amd.com>
 <20200727145840.25142-3-Vishnuvardhanrao.Ravulapati@amd.com>
 <c467e2ee-727d-4bf5-8ceb-90c784245a43@linux.intel.com>
 <20200727160941.GE6275@sirena.org.uk>
In-Reply-To: <20200727160941.GE6275@sirena.org.uk>
Accept-Language: en-GB, en-US
Content-Language: en-US
msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=9aa82977-d922-4132-87b5-683ef987f072;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=0;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal
 Use Only -
 Unrestricted;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2020-07-28T06:45:55Z;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=amd.com;
x-originating-ip: [124.123.114.166]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 4bb3b1ed-55ce-4d2d-5cc0-08d832c3d29e
x-ms-traffictypediagnostic: DM5PR12MB1500:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR12MB1500EE8EBECEEB05F886CA92E7730@DM5PR12MB1500.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1824;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 3VTvR+ydbKb0gkf9QMjYLLxc3PJKpIw365pnldwfbCpuEnA9YAGBQwmJVY9RJVxnegSzaZx9dF5M4Jivys17rhmN8VksYe4cQATRDdl+fBrdJqCgMhpQo+fLO5IzTAmmOlX/sUJhy8XFoB30YQaLaflobPHK6TQpxk6m516q2t+V/DSEgXCbyZE03haV8/x9YYPa+dqUTQVtiJQsC/4JQNR6WNUdzsg5xUvW2d1R7Pd4APJ6mYd9+ZLXhAasqvddNBOcd9oPqVKfiH/60xxt1bibXh/85mNhN99RKdzuSxuk5u7RE615EnQ9rvidrpYJwiHG6RQ8vAyeSHOE7gGRQw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1201MB0139.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(2906002)(66446008)(64756008)(66556008)(66476007)(66946007)(71200400001)(76116006)(86362001)(83380400001)(55016002)(7696005)(26005)(53546011)(8936002)(6506007)(9686003)(478600001)(33656002)(8676002)(54906003)(5660300002)(316002)(4326008)(186003)(52536014)(110136005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: 2aNVSRRBJq8xS+apKQ2JEIoj0wb/m6/VkqVASypk5VZptonMjnbgftACTQPVRO9FZdA13zSWEj5iJeBemTkd7rjyyhwbEGpELVfdf2FoUTJjxWoHu7+QVGKEfvFRTV7aDM0NfqCMysiSdM6FzYVPJcjJ3lLYpsftDaGvQzLGwdxwcUVuz/tHYqLQu0mikUUOLtfWRDQBAWthfJzGWF3ZYevrb6uaaY45MHgTXmTis0uyNkP7iRin2Uq+7pNMpFf53/AigU0Srbn+zpx07TuMQd3j9QtghsT6YJF+ikdgC/fttNNztXX6W9I6MkwV0iPzVpRxGDh7TDRuV/ylBHqB81pSotwD+zd7aZCliHo3gEymL70f8zf66uA/kXS8BEge0YyID3QrE1auaabFXtdMYWZOR0aibHqRf0mKUGBHP/iKfFDcKmZbpeoNsmD4WHSH2j9/qfu9awlf1N5icdR79OWzTCCq9QvohyCnFuGLPRKK151VlHmuNKDAo6lZ1KBA
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1201MB0139.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bb3b1ed-55ce-4d2d-5cc0-08d832c3d29e
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2020 06:59:50.4761
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AEX7BpN8kJSmHZMfN2ybtnWSYPaZKnVH/Z6N7mEGrvoo+QGgILRcLMlrb6uIpX8/v6MEy3WLV+ZkHgAvhZukAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1500
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[AMD Official Use Only - Internal Distribution Only]

So Actually for rt5682 codec Now in 5.8 there are three flags :
SND_SOC_RT5682
SND_SOC_RT5682_I2C
SND_SOC_RT5682_SDW

But till 5.7.8 we have
SND_SOC_RT5682
SND_SOC_RT5682_SDW

So in our design we were using SND_SOC_RT5682 which build snd_soc_rt5682.ko
Creates the respective codec_dais as defined in that .ko

If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creat=
ing the expected codec_dai links.

As there are three flags defined in codecs, I expect that previous one whic=
h we were using(SND_SOC_RT5682) is not a wrong flag and I expect to use
SND_SOC_RT5682 as it is still available.

Thanks,
Vishnu


-----Original Message-----
From: Mark Brown <broonie@kernel.org>
Sent: Monday, July 27, 2020 9:40 PM
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: RAVULAPATI, VISHNU VARDHAN RAO <Vishnuvardhanrao.Ravulapati@amd.com>; m=
oderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... <alsa-deve=
l@alsa-project.org>; Arnd Bergmann <arnd@arndb.de>; open list <linux-kernel=
@vger.kernel.org>; YueHaibing <yuehaibing@huawei.com>; Takashi Iwai <tiwai@=
suse.com>; Enric Balletbo i Serra <enric.balletbo@collabora.com>; Liam Gird=
wood <lgirdwood@gmail.com>; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; D=
eucher, Alexander <Alexander.Deucher@amd.com>; Agrawal, Akshu <Akshu.Agrawa=
l@amd.com>
Subject: Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt568=
2

On Mon, Jul 27, 2020 at 10:31:24AM -0500, Pierre-Louis Bossart wrote:
> On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote:

> > changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, This flag
> > which was previously set as SND_SOC_RT5682 used to build rt5682
> > codec driver but by changing into SND_SOC_RT5682_I2C is preventing
> > to build rt5682 codec driver and machine driver fails to probe.So
> > Reverting the changes.

> The split between I2C and SoundWire means you have to choose the I2C
> or SDW mode. Selecting the common part looks very strange.

Right, and I can't understand the commit message at all.  What's the actual=
 issue here and how could this fix it - in what situation wouldn't you need=
 one of the bus modules?