Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp85839ybg; Tue, 28 Jul 2020 00:12:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHrsTCd7XBlw02g5gN5NfUYmXYNCxajdCu1qeAR5WAvZGGKXD9txbkMEKMT6fmYtl2vOsQ X-Received: by 2002:a17:906:6a5b:: with SMTP id n27mr5539927ejs.154.1595920358450; Tue, 28 Jul 2020 00:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595920358; cv=none; d=google.com; s=arc-20160816; b=F1esJzEjBigRy9szeA4s44qAAxvxXfXwLS9ii751akAZ34Ps5vv9IyEpG107EffIMB rClAxVB9xFnjQGLP0Tbhe7q5r06Q7x4JZm6fe/dUMPOKGb3MLUbdJa1IQKTU2qTCrNOI yTO+1s/X7ShHG0pezCgowZS/IBTo8j/cxGRXOrokVXKtacJyiKxvQEebeoMEcxOQ2t3H IuW72xEOn7gID4RX4dvVmKaRl2dgvgS+ixF+/dBTeixcxmoxza3fwl2TnySvLNjFYphv 2kf7hq6kqQWPXMS7oFFpkuZVVb2VyeivIqsn37TibG1oxrBN+c7sbq80XCF2w8FpKOw7 jOUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=D8wxcEOtksG+N/lm6WuH35LMjkxzkK5Kk4KGkYKOAHk=; b=SttiVbRjSwpPHsYA83H7WVrgIRvCFnJQdkxO9IpswCqNpU1gbLt+oRYDVpErpitZ/u a7thAe/LIW1L3YJxibw1KSX9CtXn2VGiCBf8juku+aWa5iVJGPJ0HbVc4SR17QEc174c mtfv/tJxM7VtvlB9tPpZnPYqGMEfNr6V8oVijn92/6X4RLIH/SevUBgXf0D9PFafnTh+ efJrG08t4MxL6qhBJA2+PjkoTrAIjoFC3HJAEwZDfu8VAsfK2IK0njkk0W/tNqPOpbN9 5Bk8F/Aiyruyd2t5sxP60Ckhvxw3BGkXB/4rS/0mRC9LsjwTgvMuDAvjwzEx3vVLpSWh sWHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aqrQ8Mo+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qx20si6973280ejb.489.2020.07.28.00.12.15; Tue, 28 Jul 2020 00:12:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aqrQ8Mo+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbgG1HLz (ORCPT + 99 others); Tue, 28 Jul 2020 03:11:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:49240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726854AbgG1HLx (ORCPT ); Tue, 28 Jul 2020 03:11:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0F5E20792; Tue, 28 Jul 2020 07:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595920312; bh=yJacfktf1QlvWuBwJGBrSDfCg5HGJQKMtce+4d5/fk0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aqrQ8Mo+HL6du7DoyMbdhlBQcK1gRHxV1aPZhqqTRYe8vACaWkp9Q0ZcQdcP6NVe/ P0Eb+zHnVno9eEb1C1KFOLwACzLsW00a62hbmIP+rUjzGfx/623VyjBZ5m480/B7b1 N6bq9D2+k+f1dyU1054inelNWy3mDyUqJMqhukgY= Date: Tue, 28 Jul 2020 09:11:45 +0200 From: Greg KH To: Rustam Kovhaev Cc: davem@davemloft.net, kuba@kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: hso: check for return value in hso_serial_common_create() Message-ID: <20200728071145.GA348828@kroah.com> References: <20200728064214.572158-1-rkovhaev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728064214.572158-1-rkovhaev@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 11:42:17PM -0700, Rustam Kovhaev wrote: > in case of an error tty_register_device_attr() returns ERR_PTR(), > add IS_ERR() check > > Reported-and-tested-by: syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com > Link: https://syzkaller.appspot.com/bug?extid=67b2bd0e34f952d0321e > Signed-off-by: Rustam Kovhaev Looks good, thanks! Reviewed-by: Greg Kroah-Hartman