Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Jul 2020 09:26:51 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Peng Fan <peng.fan@nxp.com>
Cc:     "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot
Message-ID: <20200728072651.zcflghll4wa7rm55@pengutronix.de>
References: <20200724080813.24884-1-peng.fan@nxp.com>
 <20200727063839.kfgrtperzkygvjr2@pengutronix.de>
 <DB6PR0402MB2760FBC0109E98A447BB716588720@DB6PR0402MB2760.eurprd04.prod.outlook.com>
 <20200727075441.lgscydoj3txupeay@pengutronix.de>
 <DB6PR0402MB27605640244CE751317E6DE888720@DB6PR0402MB2760.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="wxnuv5vf765geiib"
Content-Disposition: inline
In-Reply-To: <DB6PR0402MB27605640244CE751317E6DE888720@DB6PR0402MB2760.eurprd04.prod.outlook.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--wxnuv5vf765geiib
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 27, 2020 at 09:18:31AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and ear=
ly
> > boot
> >=20
> > On Mon, Jul 27, 2020 at 06:44:32AM +0000, Peng Fan wrote:
> > > Hi Oleksij,
> > >
> > > > Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and
> > > > early boot
> > > >
> > > > Hi,
> > > >
> > > > On Fri, Jul 24, 2020 at 04:08:03PM +0800, Peng Fan wrote:
> > > > > This patchset is to support i.MX8MQ/M coproc booted before linux.
> > > > > Since i.MX8MQ/M was not supported, several patches are needed to
> > > > > first support the platform, then support early boot case.
> > > > >
> > > > > I intended to included i.MX8QM/QXP, but that would introduce a
> > > > > large patchset, so not included. But the clk/syscon optional patch
> > > > > for i.MX8QM/QXP was still kept here to avoid rebase error.
> > > >
> > > > Thank you for your work.
> > > >
> > > > Can you please provide more information about big picture of this w=
ork.
> > > >
> > > > If I see it correctly, we have here support for i.MX8MM, which seems
> > > > to be able to fully control Cortex M4 (enable CPU core, etc...).
> > >
> > > Yes.
> >=20
> > In this case, I would recommend to mainline the i.MX8MM part
> > first/separately.
>=20
> Only the last patch is to support earlyboot, all others is imx8mm part.

ok

> >=20
> > > >
> > > > And other case, where remoteproc is running on application processor
> > > > and can't or should not touch M4 (i.MX7ULP, i.MX8QM/QXP..). Since M4
> > > > provides some functionality, you are trying to reuse remoteproc
> > > > framework to get resource table present in ELF header and to
> > > > dynamically load things. For some reasons this header provides more
> > > > information then needed, so you are changing the ELF parser in the =
kernel
> > to workaround it.
> > >
> > > Not exactly.
> > >
> > > For i.MX8MM, we support two cases. M4 kicked by U-Boot, M4 kicked by
> > Linux remoteproc.
> > > For i.MX8QM/QXP, the typical usecase is M4 kicked by SCFW, but we will
> > > also add M4 kicked by Linux remoteproc.
> > > For i.MX7ULP, I would only support M4 dual boot case, M4 control
> > everything.
> >=20
> > From current state of discussion, i'm not sure what role plays remotepr=
oc in
> > the scenario where M4 is started before linux. Especially if we are not=
 using
> > resource table.
>=20
> We are using resource table from an address, not in elf file.
> This is the new feature in Linux-next to support coproc booted early.
>=20
> >=20
> > > The reason the change the elf parser is that when M4 elf is loaded by
> > > Linux remoteproc, It use memset to clear area.
> >=20
> > The use of memset, depends on ELF format. Fix/change the linker script =
on
> > your firmware and memset will be never called.
> >=20
> > > However we use ioremap, memset on ARM64 will report crash to device
> > > nGnRE memory. And we could not use ioremap_wc to TCM area, since it
> > > could have data correctly written into TCM.
> >=20
> > I have strong feeling, that we are talking about badly or not properly
> > formatted ELF binary. I would prefer to double check it, before we will=
 apply
> > fixes on wrong place.
> >=20
> > > Maintainer not wanna to drop memset in common code, and TI guys
> > > suggest add i.MX specific elf stuff. So I add elf handler in i.MX cod=
e.
> >=20
> > I think, removing memset may damage current users of imx_rproc driver.
> > Since, like I said: the use of memset depends on ELF format.
>=20
> In my elf file, the last PT_LOAD contains data/bss/heap/stack. I'll check
> with our MCU guys, we only need the specific data loaded.
>=20
> Elf file type is EXEC (Executable file)
> Entry point 0x1ffe0355
> There are 3 program headers, starting at offset 52
>=20
> Program Headers:
>   Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
>   LOAD           0x010000 0x1ffe0000 0x1ffe0000 0x00240 0x00240 R   0x100=
00
>   LOAD           0x010240 0x1ffe0240 0x1ffe0240 0x03e90 0x03e90 RWE 0x100=
00
>   LOAD           0x020000 0x20000000 0x1ffe40d0 0x00068 0x0ad00 RW  0x100=
00
>=20
>  Section to Segment mapping:
>   Segment Sections...
>    00     .interrupts
>    01     .resource_table .text .ARM .init_array .fini_array
>    02     .data .bss .heap .stack

Here is an example of formatting ELF for remoteproc:
https://git.pengutronix.de/cgit/ore/OSELAS.BSP-Pengutronix-DualKit/tree/loc=
al_src/remoteproc-elf/linker.ld
https://git.pengutronix.de/cgit/ore/OSELAS.BSP-Pengutronix-DualKit/tree/loc=
al_src/remoteproc-elf/imx7m4.S

In this example I pack linux in to remoteproc elf image and start linux
on imx7d-m4 part.
Will be interesting if you can do the same on imx8* SoCs ;)

Regards,
Oleksij
--=20
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--wxnuv5vf765geiib
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEERBNZvwSgvmcMY/T74omh9DUaUbMFAl8f0zYACgkQ4omh9DUa
UbOaNg/9GDt95BZraGTVvjG172AgwIpQpn4nLaR1y8fhPcANYIj+wb03/+N2sJMK
jW2NDTHGovbzjaDpwpnFQCjVWKH2BdsDeuRyZWjVLtM5E038nPu5Jlz8nZLF+p1g
NFbbze2ugHwfVc72i0wABbdc61vyL753WL2783zY0+6sFohc9pe1fbh+mBwf7/ai
8gVyDJFlhYorXupOAUqag84H9UG36DoB/7fOm0Nq3y9SUo0c3DU+ryu1jykTZ3IX
GnFE/0eR1X1B6juRXdBDNHMMwQX2wCQtdPsu+T5trlVc59fzWgm7GTa2o5DVO24r
y8joWcRIXRCXIFqBNIjBmXLSTG+MKflKLoQij8tqT3BteSqdUpw/IIvsab2oRRpm
seaQveN8xJZ2k72n3jgLJlyN5w7aylpHkDbqhwUp4Fv6D2n/vZvLBknCanjQ2GKB
BHbOeIC7eqkkn2Xr2eVk7aLFS1BfCr0CT9iTNlNHJYoNgulRg/ccvL72Y/WLvEaS
gr9GIe8eLQF7pIsK0LmqJoozUlD6z5sJ1cVbsjsgnZIRagFHHis8aRccxQkPAxHu
ks5DQntOkVTi7rabBtV78p9EXUJCST4ZEmah4Wsv6tsmQIjgC7qLqojop1pYhbAF
F1xrVdQDXYH3dhf7eoAOUEqUL2mRzH755Rjn0dIe9tPruF/8hgc=
=5rSP
-----END PGP SIGNATURE-----

--wxnuv5vf765geiib--