Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp99644ybg; Tue, 28 Jul 2020 00:37:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGP0XZDNMD+36MGG26uujAijWPvhap3MzJywuNjCBJoYRB0KHKBzGxIAUWJFtJGWB0lkEe X-Received: by 2002:a17:906:17c1:: with SMTP id u1mr20107889eje.536.1595921868312; Tue, 28 Jul 2020 00:37:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595921868; cv=none; d=google.com; s=arc-20160816; b=i10hrENMQlYJ9d0+E8XnzS7/opQs1706CNq4+j3fBEjzo025EY1fp+CR5lofgDkT/W GrlFDYWbKGfeG2IpZp99fqfC1YKf0pDCWeWRPU2YBzPRhE+4lFDN20Frc0Qkier093dJ fmB/ex9kLYFwKk4OWLb795PbYKu0lIo6rka4wJPAqXTt7nFJuoFq3WeiJ3MHRl2ogNtx mdm46C8kzGq+QQ3EtXqCu8Rrg7v/y4eMAQIe0mYVEcXSz8wki/wMjguI8oaIdt+alaFJ 16xwYbBCvV7geJToLIkeJZ9i3fOPqr6pSKL34a7GWwihtC7SLxx6yj1XK4Wo63IcV2me oumw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=GCtW5tjuxaVJCAVwYvqgSD5+Nq9caPLs/8RWHFhoN7c=; b=HbT/CTKFwBeKlDtyNxe67cbC6QHan9jKhxA3GC/5cSzIEYIv/DWXAV5u4L4+FIwrTZ pMKi4oEI/J0XZMVGKD4KcGZjPjcC2wHcAw1U6bVe/TPSwvVv5CIny5v5qCRs+CnTKV1z 5RoHuYknsgPeZRmmQ+9KvXPaCudB7dZBa4dzEctCa/olTmWqQb1ZioBRSxiYZXVQpEGK s52kGFKkE/LyyyIMWlvmPmyjTooXI1dbKI/VwpswqL09er2dp858xy/LG4aVNt9y4+Ac lAQvFSOR9mzKD/w1beNYDKcos7mjJdJFKbf6GSzNoPKB0hTWb0Ck+X9CiT8DEp0qk1J0 liYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk23si7977953edb.219.2020.07.28.00.37.26; Tue, 28 Jul 2020 00:37:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727905AbgG1HfP (ORCPT + 99 others); Tue, 28 Jul 2020 03:35:15 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:55013 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbgG1HfP (ORCPT ); Tue, 28 Jul 2020 03:35:15 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MuDPf-1knLMT1jCv-00ucez; Tue, 28 Jul 2020 09:35:12 +0200 Received: by mail-qt1-f170.google.com with SMTP id t23so11082490qto.3; Tue, 28 Jul 2020 00:35:12 -0700 (PDT) X-Gm-Message-State: AOAM531bLlf1hTCvlV7+0iPP+VmKnVqyC0bNmn7Y42CWdYosjblaUS1A O2xQYKUZowkVbYKRdZRpHwqd6cAhzo/wmJzTJc0= X-Received: by 2002:ac8:688e:: with SMTP id m14mr18758364qtq.7.1595921711141; Tue, 28 Jul 2020 00:35:11 -0700 (PDT) MIME-Version: 1.0 References: <20200728022859.381819-1-yepeilin.cs@gmail.com> <20200728053604.404631-1-yepeilin.cs@gmail.com> In-Reply-To: <20200728053604.404631-1-yepeilin.cs@gmail.com> From: Arnd Bergmann Date: Tue, 28 Jul 2020 09:34:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH net v2] xdp: Prevent kernel-infoleak in xsk_getsockopt() To: Peilin Ye Cc: Song Liu , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , Dan Carpenter , Greg Kroah-Hartman , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Martin KaFai Lau , Yonghong Song , Andrii Nakryiko , KP Singh , linux-kernel-mentees@lists.linuxfoundation.org, Networking , bpf , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:ea85R/l0RhqD2jar4GIsAVuSbP8q+tqdgYpDciLzCh2vczIgPY7 0U7W0m2+00t53Ngi4QwIblA7e7OymA/4xAtHe2b8aw+7iTNvkrqMKqcI6BkX8Is2/6VTXsx VsmbEKJXUIHbzmJRfuYZstroWcFWqHot7DKwQHOsZ9d0vadiyYovN+9l3I20dV2LOIEpQXN OPpYUr2IANQwBfCReeGNw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bBIWiQconYU=:etXMGO21NeYgUooWd7eSo8 KAZRJ8GQXB4d/stO00LAjEEM01ZISG881LiYnQN9QLMq2RBGmdrqneORsJ8WwEtrZPyQPLmSZ XxOjdLm9zwQUOKfXnSXWB6yvDchCz6LutZFG3nwlbgPi6/6VOsZlyYaUsHxS5sb798juHqBCn DE74HDiIhjBp0c3cGb+Dg7I8E1B8XaDYbpd7rwJuw8n2vGnibK1mpeWFXjqPBOzbDEN/JeS0H DLvUWpX0Kaq5SnbXzbQvbBLzV9WEFda1d1TLAlldYDgJrqVZvOrBKB3tc2vJUyt17ZNcc+92Y zSoK9/N86OnJhWHT4IlbIer4WfISWLOG10ErIf5A1ym2WGeq+872pU3LvAd4OsoYhCZ+p3YwJ WCuhBOjTbBs31dCcektc2o6pvtuSxnbiBMHohEwLi8ZXm4HH24fo9lrwSh09mVGgIMlOyaP6e FfC8X1M/MoNba2MbAkApHSjyDWEqUJVVgPHVqEVrIsQMEn6uX2H31bPipfDr1sxw55glBsc/n qV6V6Kf6oVJOTMC5swNDQzKtlSybW1gPsMW766UI/M52eB83yfBgPuLyGpuLd0hZQTS8FQkDN ZZe+0V7qo8L6jzSFVP8a+vey1Tpvct8MdjmoLUejc1Agc92unH+q7G3qREGj5kwpO+zlLHWv5 O6z6H2SBjbRik+CVJyhWpMVk5JQiMXfku9mJ0w7NilGRkU0MFwJ8pPtiH4R2AoK1zxmBAgO+n k2yVK4RQYURdeGkjriz6bIYKGfMRjDNoO7uJI0622VhDb/+8aC2BnVgBvKUnyFVlEdaNnhpj/ h/janOHjW+5Y6yVJjxGPZisonAEwxXhIJyJBUr3vDK+upLCCYMO2COzPZPZJE4BVAT33CRp9r 23M2m8Ql3mS9UyP1YZMjjS167kxcUmHIgz7rEdlf18ewPLShiAyMIbtvzhCfVZ2wwTJuG/BMS mFdXXRr4ELUgnxr2MT5i+49vnbohHmKS+JlQU1nLYkgBqv9aCFuQ4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 7:37 AM Peilin Ye wrote: > > xsk_getsockopt() is copying uninitialized stack memory to userspace when > `extra_stats` is `false`. Fix it. > > Fixes: 8aa5a33578e9 ("xsk: Add new statistics") > Suggested-by: Dan Carpenter > Signed-off-by: Peilin Ye Acked-by: Arnd Bergmann