Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Christian Eggers <ceggers@arri.de>
To:     Marco Felsch <m.felsch@pengutronix.de>
CC:     Fabio Estevam <festevam@gmail.com>,
        Martin Kaiser <martin@kaiser.cx>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Arnd Bergmann <arnd@arndb.de>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        <linux-kernel@vger.kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        "Matt Mackall" <mpm@selenic.com>, Shawn Guo <shawnguo@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] hwrng: imx-rngc - setup default RNG quality
Date:   Tue, 28 Jul 2020 10:47:29 +0200
Message-ID: <2473540.1Sv8tvBx5K@n95hx1g2>
Organization: Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
In-Reply-To: <20200728074817.hlevn7ex2hckdbvi@pengutronix.de>
References: <CAOMZO5ASnj7SpjjAEpWjRK-vMpFFKU00=rxKeBtaMSKE9pkX1g@mail.gmail.com> <20200727124552.4336-1-ceggers@arri.de> <20200728074817.hlevn7ex2hckdbvi@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Marco,

On Tuesday, 28 July 2020, 09:48:17 CEST, Marco Felsch wrote:
> Hi Christian,
> 
> On 20-07-27 14:45, Christian Eggers wrote:
> > When hw_random device's quality is non-zero, it will automatically fill
> > the kernel's entropy pool at boot.  For this purpose, one conservative
> > quality value is being picked up as the default value.
> 
> IMHO your value is not conservative enough and the commit message should
> explain why we should use 900. Unfortunately I had not enough time to
> send my patch addressing this. However please check my commit message
> why 900 is not good:
ok, you caught me. I found the value of 900 in several other drivers and 
simply took it. Even parts of my commit message were simply copied...

As I have no real idea about determining the right quality, I will leave this 
task for you :-)

Thanks
Christian