Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1584105767-11963-1-git-send-email-kevin3.tang@gmail.com>
 <1584105767-11963-5-git-send-email-kevin3.tang@gmail.com> <CACvgo52_KT6O79PujodCPbkegP6LLwuVSFEoRdbarZ=y50B63A@mail.gmail.com>
In-Reply-To: <CACvgo52_KT6O79PujodCPbkegP6LLwuVSFEoRdbarZ=y50B63A@mail.gmail.com>
From:   Kevin Tang <kevin3.tang@gmail.com>
Date:   Tue, 28 Jul 2020 18:18:01 +0800
Message-ID: <CAFPSGXaERhtja=hZdKcuBJf-wtiT4RbM50UcT2wNBBAa2bq-Uw@mail.gmail.com>
Subject: Re: [PATCH RFC v5 4/6] drm/sprd: add Unisoc's drm display controller driver
To:     Emil Velikov <emil.l.velikov@gmail.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Sean Paul <sean@poorly.run>, Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Baolin Wang <baolin.wang@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Emil,
Sorry, I left for a long time because of other things. Now i'm back~

V6 fix access registers via readl/writel, check unsupported KMS
properties (format, rotation, blend mode, etc) by plane_check callback
ops
and remove always true checks for dpu core ops

Add changelog within the corresponding patch from now on, thanks for
your advice.

BR,
Kevin


Emil Velikov <emil.l.velikov@gmail.com> =E4=BA=8E2020=E5=B9=B43=E6=9C=8820=
=E6=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8A=E5=8D=882:07=E5=86=99=E9=81=93=EF=BC=
=9A
>
> Hey Kevin,
>
> On Sun, 15 Mar 2020 at 23:19, Kevin Tang <kevin3.tang@gmail.com> wrote:
> >
> > Adds DPU(Display Processor Unit) support for the Unisoc's display subsy=
stem.
> > It's support multi planes, scaler, rotation, PQ(Picture Quality) and mo=
re.
> >
> > Cc: Orson Zhai <orsonzhai@gmail.com>
> > Cc: Baolin Wang <baolin.wang@linaro.org>
> > Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> > ---
> >  drivers/gpu/drm/sprd/Makefile       |   5 +-
> >  drivers/gpu/drm/sprd/dpu/Makefile   |   7 +
> >  drivers/gpu/drm/sprd/dpu/dpu_r2p0.c | 750 ++++++++++++++++++++++++++++=
++++++++
> >  drivers/gpu/drm/sprd/sprd_dpu.c     | 501 ++++++++++++++++++++++++
> >  drivers/gpu/drm/sprd/sprd_dpu.h     | 170 ++++++++
> >  drivers/gpu/drm/sprd/sprd_drm.c     |   1 +
> >  drivers/gpu/drm/sprd/sprd_drm.h     |   2 +
>
> Seems like v5 (patch at least, I did not look at the rest) does not
> address a handful of the feedback.
>  - Access registers via readl/writel, instead of current approach
>  - With ^^ you can drop the compiler workaround
>  - Checking for unsupported KMS properties (format, rotation, etc)
> should happen in the XXX_check callbacks
>  - Remove always true checks, around the (rather moot) abstraction layer
>
> For the future, please keep the revision/changelog within the
> corresponding patch. This way reviewers can see, from the onset, what
> is addressed.
> Look at `git log -- drivers/gpu/drm` for examples.
>
>
> -Emil