Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp203633ybg; Tue, 28 Jul 2020 03:57:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMo1mvBGfo1Dcaz188mIPrQwvoc1fD+96XSNy11jE086H+O6koCLX9BRo6eTNiPMEM/ZkP X-Received: by 2002:a17:906:7153:: with SMTP id z19mr22909479ejj.319.1595933831494; Tue, 28 Jul 2020 03:57:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595933831; cv=none; d=google.com; s=arc-20160816; b=hPuTEXvGGHfZl6vuZylxPlcMCKc9wH3XJuuYKd04h1BMfDZVoht74zBmcbBFm2+O/w onb4i8rGM0vO9bK3kQ0rDVcNhMLeb04czycp2/tX5ymB8aQLEQal2YAh6j5CA+k06yKC xTFTJlPm+DR90u2D5tLHX78g9+AIOJAYwxYUXMjPovZ9IHNuEx8bhETsjSTWNpPSAcZx fEwqPGlRI3dZfySUJfdHxuPlkmLyI2Gh8DXOCjco1VTI212CRBemIE02pvMpkhVay7S+ NXPEjICr7MIyBRmDk9DYCieLxYZx+f7PA/LYXI35OF5hW9TMhHPOrwyHUhplYuVPDLuF 52kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=uhvGq0HgWffX1SUm40NP1O/C5jJZ5nIvQ7twCsLq85Q=; b=SHpEJ0RrT9o7hnJzCvklL672BwKh4hhzXVYdbAnBNq3XOQ1CtLoCLoE0HGeypm84ne 7AZGR9kpzwoqb6f28yfzlByXDeHveSTVTbefmUmCm5Ivuymog3acooH/CJNuApCrT+z8 hi32n6O+eHQsxS6Ko41jr0ebiIOKHQQZe5KIFeESnPkkYjvU2qrAyMcbtv3/1sCi2AWY w/5KN80/nMous+s5Lmu40HBgkFZoxlNz7Dxo6O7btwdXh9N7WSLaw1oWbsP1jkyPUJNl G1GWjhMXYe+tvdLmaWJ+wmfxR6ehS4Dq0csj4fwZ/DixVoThJTFr4ru4Lcbm4kKTXJfG 9jZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GaqX56Rb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u24si4362205ejx.88.2020.07.28.03.56.49; Tue, 28 Jul 2020 03:57:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GaqX56Rb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728943AbgG1K4U (ORCPT + 99 others); Tue, 28 Jul 2020 06:56:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:33210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728763AbgG1K4U (ORCPT ); Tue, 28 Jul 2020 06:56:20 -0400 Received: from kernel.org (unknown [87.71.40.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F93A204EA; Tue, 28 Jul 2020 10:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595933779; bh=rNeOQgk8Ja8EnwwwD3eYzStK24lMrD6z0cTMgy9a9QQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GaqX56Rbj+N1Mz6UyTAyoeiV2UjmyQ1JRRE5tNv2GNU4C8YMxHr+kbNtL4JzJlsAy ScdjYPyI8moETB7oZ34zmIQmli78wpYsgkku4f7CIjv3woY2fEo2HxXSUsaNO4HEay kodVMJnUU7dTJtF+OWGSFGl3TO2fwrpo3QfCz2LQ= Date: Tue, 28 Jul 2020 13:56:02 +0300 From: Mike Rapoport To: Ingo Molnar Cc: Andrew Morton , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Dave Hansen , Ingo Molnar , Marek Szyprowski , Max Filippov , Michael Ellerman , Michal Simek , Mike Rapoport , Palmer Dabbelt , Paul Mackerras , Paul Walmsley , Peter Zijlstra , Russell King , Stafford Horne , Thomas Gleixner , Will Deacon , Yoshinori Sato , clang-built-linux@googlegroups.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org Subject: Re: [PATCH 14/15] x86/numa: remove redundant iteration over memblock.reserved Message-ID: <20200728105602.GB3655207@kernel.org> References: <20200728051153.1590-1-rppt@kernel.org> <20200728051153.1590-15-rppt@kernel.org> <20200728104440.GA222284@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728104440.GA222284@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 12:44:40PM +0200, Ingo Molnar wrote: > > * Mike Rapoport wrote: > > > From: Mike Rapoport > > > > numa_clear_kernel_node_hotplug() function first traverses numa_meminfo > > regions to set node ID in memblock.reserved and than traverses > > memblock.reserved to update reserved_nodemask to include node IDs that were > > set in the first loop. > > > > Remove redundant traversal over memblock.reserved and update > > reserved_nodemask while iterating over numa_meminfo. > > > > Signed-off-by: Mike Rapoport > > --- > > arch/x86/mm/numa.c | 26 ++++++++++---------------- > > 1 file changed, 10 insertions(+), 16 deletions(-) > > I suspect you'd like to carry this in the -mm tree? Yes. > Acked-by: Ingo Molnar Thanks! > Thanks, > > Ingo -- Sincerely yours, Mike.