Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp249535ybg; Tue, 28 Jul 2020 05:13:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLoonaOMfKIe0lvgQ5fOQ+111mkr41kYJZLCMsXinhWMQZ4QOnteEulFMTzLN2hm/7LVzt X-Received: by 2002:a05:6402:c86:: with SMTP id cm6mr8069774edb.205.1595938392916; Tue, 28 Jul 2020 05:13:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595938392; cv=none; d=google.com; s=arc-20160816; b=lP4srezi0Ijxt/Vou/XYqgN9PlfgjoOwvv3k3+1WvawNJXpU2vUdyXeK0R0TklRGlt /ZSt2LGaYeMBfb9SMzQB9LCuuhn/UjEzc4uPsRnDsioduYtKZggx6GqZ3fof01xbMnBR 4jyEnQnVSJ0jMWLveZQeWXqAt+9KIXq4WCc2flEYDVGilPfsSpdsci8G3kgMmAebA517 DDqmouZqLLeSCH9Jym19id8Jhd0tXlkQ9db57WWwq1GStHRwX7CfRSGvqzxq9NZ90Ud1 JBzzh8rVNtyp8yqEflwUIYqu6EnunyTjFfHKnZ6+l5NG4zk2b0f46XTTIkdL/XQAYg/s NzxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=6/A9tlV6apMzxIMyEDAu6vhVN3Y1Dh7TDy7Vh3W2aek=; b=ExjotkdMeyXtw2Y2vB0iC4aRGWfc9ijOp53jbLVsSsHcU4+BnBK4Gr5uN+wrRJrFai FMIvDAW8q0Df5Coi2PjFZ7AHm/ApW2u0sIjglQ939CDX+MzRl/rv5ED2KJ9E3C6Wkd8M OKhii+5NhC8YRH2iELeaYNQBZuLAE3mmdA0FmrtscfNvyl6DlcvU+spK+T2E08OV+j7t 955VywarLP65jGw9txnwah2W5H/L+dEqzvZh7SsbiEN4yuS8WKkELEOL+AXsNHmFr9xI I4RlPBl60SihDAiDuito2qoLs8LM9A7pdIpVwu9WPtpYCLDA5loFod9dRJlhEBeIcoKi Gxzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id si6si5208610ejb.331.2020.07.28.05.12.50; Tue, 28 Jul 2020 05:13:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729234AbgG1L4S (ORCPT + 99 others); Tue, 28 Jul 2020 07:56:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:47349 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728129AbgG1L4S (ORCPT ); Tue, 28 Jul 2020 07:56:18 -0400 IronPort-SDR: eDUbmE8oUZ8Ce19dRqYP/LVJuDH+ICaHKGshqT9GV2I0hogO1UhHPWa6wVxV7CxRjKxz25jzf9 bc7rVtUdWsnw== X-IronPort-AV: E=McAfee;i="6000,8403,9695"; a="169305966" X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="169305966" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 04:56:18 -0700 IronPort-SDR: tsHcer/XF3MYNZfSm8piNeuMMBqLcG4D6qBKoOrrhgtVpI4L/HTkp+m0xhTEF9DEAgp8gXxE1j 2D9a52l7baEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="394310536" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 28 Jul 2020 04:56:15 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 28 Jul 2020 14:56:15 +0300 Date: Tue, 28 Jul 2020 14:56:15 +0300 From: Heikki Krogerus To: Kyle Tso Cc: linux@roeck-us.net, gregkh@linuxfoundation.org, badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] usb: typec: Comment correction for typec_partner_register_altmode Message-ID: <20200728115615.GD883641@kuha.fi.intel.com> References: <20200714033453.4044482-1-kyletso@google.com> <20200714033453.4044482-2-kyletso@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714033453.4044482-2-kyletso@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 11:34:52AM +0800, Kyle Tso wrote: > typec_register_altmode returns ERR_PTR on failure. > > Signed-off-by: Kyle Tso Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/class.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index c9234748537a..02655694f200 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -580,7 +580,7 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity); > * SVID listed in response to Discover Modes command need to be listed in an > * array in @desc. > * > - * Returns handle to the alternate mode on success or NULL on failure. > + * Returns handle to the alternate mode on success or ERR_PTR on failure. > */ > struct typec_altmode * > typec_partner_register_altmode(struct typec_partner *partner, > -- > 2.27.0.389.gc38d7665816-goog -- heikki