Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0BX2zmYYAzYYoDZ3lhGRBz9VzcapNAgBdnMgoZqwo+MbZEBVfMqlroEKOjcCDnUjgNn5PeaJWF
 aVYopg0uN6Iw==
IronPort-SDR: mLYBLhV0Rr0bgzl8YUEgbAlZG+BPbvPprwXO4KFMfByhgxAoZivS0VsYoXcZnEfJxqljsvDnll
 JRGXE9w40pPg==
Message-ID: <1f2ef9915cbc7f1d55c8ad54b3efa3d93a9ef608.camel@intel.com>
Subject: Re: [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes
From:   Zhang Rui <rui.zhang@intel.com>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        namhyung@kernel.org, linux-kernel@vger.kernel.org,
        kan.liang@linux.intel.com, len.brown@intel.com
Date:   Tue, 28 Jul 2020 21:16:52 +0800
In-Reply-To: <20200717083328.GA528602@krava>
References: <20200716151859.6854-1-rui.zhang@intel.com>
         <20200717083328.GA528602@krava>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2020-07-17 at 10:33 +0200, Jiri Olsa wrote:
> On Thu, Jul 16, 2020 at 11:18:57PM +0800, Zhang Rui wrote:
> > This fixes a problem introduced by
> > commit 5fb5273a905c ("perf/x86/rapl: Use new MSR detection
> > interface")
> > that perf event sysfs attributes for psys RAPL domain are missing.
> > 
> > Fixes: 5fb5273a905c ("perf/x86/rapl: Use new MSR detection
> > interface")
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> > Reviewed-by: Len Brown <len.brown@intel.com>
> > ---
> >  arch/x86/events/rapl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
> > index 0f2bf59f4354..51ff9a3618c9 100644
> > --- a/arch/x86/events/rapl.c
> > +++ b/arch/x86/events/rapl.c
> > @@ -665,7 +665,7 @@ static const struct attribute_group
> > *rapl_attr_update[] = {
> >  	&rapl_events_pkg_group,
> >  	&rapl_events_ram_group,
> >  	&rapl_events_gpu_group,
> > -	&rapl_events_gpu_group,
> > +	&rapl_events_psys_group,
> 
> I did copy & paste but did not change to psys :-\
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Hi, jirka,

Thanks for your ACK.


Hi, Peter,

A gentle ping on this patch series.

thanks,
rui
> 
> thanks,
> jirka
> 
> >  	NULL,
> >  };
> >  
> > -- 
> > 2.17.1
> > 
> 
>