Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp299432ybg; Tue, 28 Jul 2020 06:26:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwsYnpOW+ZnvT3D4dL8ET+JjPfAdCS+YVq23Qwh6cL1zhnX3bG0b8lgPB3/SdzERu+/Te6 X-Received: by 2002:a17:906:36da:: with SMTP id b26mr16664820ejc.45.1595942762639; Tue, 28 Jul 2020 06:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595942762; cv=none; d=google.com; s=arc-20160816; b=CMRuWvsen3pCZfK/uQG2CkHDizYj30uFXg5hSSiYssN3Ox6fVhaBsWKxf8Bo3SxjRz ZiTHYt2iNlg6J8tgpt16SxAGo8Gt5gRT4dLPeLdkP2SjLagVs08Pk2tF2c+UKLKUksfk Blt8KSMleAvfooEw3yM/9FNATVBHClKTyEvoGINnS/JFTI7882mfOsh6NWagTdkZuLHb R/N6aiXlFTyD8qOZy5E5DoH8OQ3F8V16bjiHBhATuCUOGxo5/J17QWHzx8yk65y7BjNC Y8sYaOJiHvRQsWvv1zdZ+kx/6Eq25F4Mk5nSbO5nsSZyPjFo9pBh5+oXjm60RQAuRqqn qf9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ANecPKxc0/I+j4txAHsemmobB7jeFpVIkoQwGkyZTmY=; b=rlM5DY3bdzUeyjL9VgiDJgjo52WiACjrVFKxdF7MSOf5D/1q7euopfRGx9oE4YMqRc KqIrWCfrmiCz1AVBGYBLbqh2895RYOBVCH2KmLTbxjEuy3RsJmAnyTmC6plM9xKwIW7i XR56qoI4SLQ1swHcWPIpBzXzV1yytWgaFi1GE+0zuVbFNwyZd3ALrf43IaE9uOhUeQDI krBWs68Uv55n3R9MP1+XMvcfpMfmNEr45vcDixYZRmAAyU3byK8Ieo4ltWqPBHgM3ln6 5392dk8NdatPELfU6bAQEGSNtVibdehq6COdJ5WdOi1c4BHXB2gUpCEZZoophFo2IOtm gFTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UwcoIU46; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o23si3015721eju.715.2020.07.28.06.25.40; Tue, 28 Jul 2020 06:26:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UwcoIU46; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730114AbgG1NY6 (ORCPT + 99 others); Tue, 28 Jul 2020 09:24:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729984AbgG1NY5 (ORCPT ); Tue, 28 Jul 2020 09:24:57 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A584FC061794; Tue, 28 Jul 2020 06:24:57 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id o1so9902053plk.1; Tue, 28 Jul 2020 06:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ANecPKxc0/I+j4txAHsemmobB7jeFpVIkoQwGkyZTmY=; b=UwcoIU469IpINOG9wZJAPb1PTIjLewpQ2ZLHrZHeuCWIKYFT0vMeZj5rUfWPOuc7jq yRdd5f3IDUlONxlXQ7C8yt7foMQuSa1cg71UWkLpd5qDY6qNB7BpP8XigiHPaIS0bU3q nNw9a9wOCSc0vNxVanJQxQwEBRg4foBZKmNeynEM3uzG+0Xz05JCpx7Ez06ILw7ZMvlH V0GfFTIbNVCMhZwF6BV+VduLqgGb5jqzSp4bCX7pKl8pNY2yqWs+B32jh0+fQBbsyks1 LFaHA3a4ckhvOdHtksqG8ZUO4j8n7eMTPrCnnUcIGRBSg61MxgWR5wImco1QGLMKRLNu G8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ANecPKxc0/I+j4txAHsemmobB7jeFpVIkoQwGkyZTmY=; b=taJWlDAf1Z8OeV7gPg/6Ot7+g9uezFVeixz67Ljnoo3qyT8ACg2evsOAODrFU3XuNr Yu5W1bkDs72SMOPISEc7XCE/HyFZRKVd3+2w9dY1h9i+qvby/qZwl9lkVW+u4IyW3x71 Fqkmh3frdF7Kr/Nvu78fHv+58X+Vvi9P3kqBPwUp3cBtGWIi+HEv7pJCztSd1yiavEeh Mpl/DXripZwLx/RFERWW8WwQmV/B34Z1W6vT/l8JNRdA49inGflqz2f+TF6x94gF6cbi FU1UHGP9NTQ6QrElMy7EG8MugZapm0h0dD2E/as5198hJTo8Sd2KbQr5wG9WatvKrnX1 BNfQ== X-Gm-Message-State: AOAM5306zixDNRLjFjxQxxJOuUVCBWla/DT5tFZP2i3AYxOo548VG2rv 5DGfZuzbg2M2DAnN9Kt7av65ZTPDLhROO11e7xc= X-Received: by 2002:a17:902:4b:: with SMTP id 69mr7494548pla.18.1595942697197; Tue, 28 Jul 2020 06:24:57 -0700 (PDT) MIME-Version: 1.0 References: <20200727122242.32337-1-vadym.kochan@plvision.eu> <20200727122242.32337-4-vadym.kochan@plvision.eu> <20200728123006.GA10391@plvision.eu> In-Reply-To: <20200728123006.GA10391@plvision.eu> From: Andy Shevchenko Date: Tue, 28 Jul 2020 16:24:42 +0300 Message-ID: Subject: Re: [net-next v4 3/6] net: marvell: prestera: Add basic devlink support To: Vadym Kochan Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , Ido Schimmel , Andrew Lunn , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , Andrii Savka , netdev , Linux Kernel Mailing List , Mickey Rachamim Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 3:30 PM Vadym Kochan wrote: > On Mon, Jul 27, 2020 at 04:07:07PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan wrote: ... > > > + err = devlink_register(dl, sw->dev->dev); > > > + if (err) { > > > + dev_warn(sw->dev->dev, "devlink_register failed: %d\n", err); > > > + return err; > > > + } > > > + > > > + return 0; > > > > if (err) > > dev_warn(...); > > > > return err; > Would not it better to have 'return 0' at the end to visually indicate > the success point ? Up to you. Actually just noticed that you are using dev_warn() for error. It should be dev_err(). -- With Best Regards, Andy Shevchenko