Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9rVtzBnD6A5OKhyNl21/X/x5qCc5m8+RXg3wl/dKLgwSuapmG2Fm/gKVgaNfrLMrjMLHR+2wX5
 dMiDTTW8BuXXcTvCT+cO0cVbtJQ3HrfrjAEE3XdgtwDb4RpzgKe2sQcW7NBw37CY8Mht3mSHVl
 IfOF/pHHFku+5MIzCokG91VqithBCYagMgdIRDRFfh81u1YnscN3bQPLHl+O1IFDD/fGVsnvFi
 MfDKte5skXU6zapRsxB59ktCqJPnsuamVDgqEkjzuK7CsIOKDbQi3UbBGwpYnV3oF9CTNZE0eE
 Tw0=
IronPort-SDR: Qo4GZXqj6aPQr1FabmXcmOi6BmJI01chr0R5EOpeCzHVZISWjmdIdMk3zcf4c3Xw/OJwGHPmLG
 0kzG3ci5mb/K2if1KTpVaV0peiEKC80UVL5hy7BHqCq1Urta/ZZI7ZJl0GgzWt2NAu/gL0YT3K
 ewlShmNXUuJ7YaHWNDWMDz0xbE/5Nk+Ys55EybHlRjzi3ptqryWlzkmUhgfHeTCYKbe1RKbNdL
 Hy4lLcr5VuTzzUXx+7k7XrzUhSThxo3ekvVcxgn1tMKG1O+TmfX6VqZgWmi6LJNO6q7jsH4f1x
 fMI=
Message-ID: <8ea0b3f655b60be02384f22c0aa4dfee9d788d71.camel@ew.tq-group.com>
Subject: Re: (EXT) Re: [PATCH] arm: dts: imx7: add QSPI
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Date:   Tue, 28 Jul 2020 16:05:47 +0200
In-Reply-To: <20200728135155.aqz3xkcwpgqmvzro@pengutronix.de>
References: <20200728112814.14158-1-matthias.schiffer@ew.tq-group.com>
         <20200728135155.aqz3xkcwpgqmvzro@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-07-28 at 15:51 +0200, Marco Felsch wrote:
> Hi Matthias,
> 
> thanks for the patch.
> 
> On 20-07-28 13:28, Matthias Schiffer wrote:
> > In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS,
> > add the
> > QSPI controller to imx7s.dtsi.
> > 
> > Based-on-patch-by: Han Xu <han.xu@nxp.com>
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com
> > >
> > ---
> >  arch/arm/boot/dts/imx7s.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx7s.dtsi
> > b/arch/arm/boot/dts/imx7s.dtsi
> > index 1cfaf410aa43..e45683e61593 100644
> > --- a/arch/arm/boot/dts/imx7s.dtsi
> > +++ b/arch/arm/boot/dts/imx7s.dtsi
> > @@ -1162,6 +1162,19 @@
> >  				status = "disabled";
> >  			};
> >  
> > +			qspi1: spi@30bb0000 {
> 
> Are there more controllers and why not using "qspi@30bb0000" as node
> name?

The vast majority of QSPI controllers use spi@ node names, qspi@ only
appears in a single example in Documentation/devicetree/bindings/, and
in no actual DTS(I) files.

There is only one controller. The label "qspi1" is chosen as this has
been in use in the linux-imx vendor kernels for years; IMHO, switching
to "qspi" would just cause unnecessary churn for dependent device
trees. I have no strong opinions on this though.

> 
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				compatible = "fsl,imx7d-qspi";
> > +				reg = <0x30bb0000 0x10000>, <0x60000000
> > 0x10000000>;
> > +				reg-names = "QuadSPI", "QuadSPI-
> > memory";
> 
> The node should begin with compatible, reg, reg-names properties.
> Pls check the current .dtsi file for examples.

Thanks, will fix.

> 
> > +				interrupts = <GIC_SPI 107
> > IRQ_TYPE_LEVEL_HIGH>;
> > +				clocks = <&clks IMX7D_QSPI_ROOT_CLK>,
> > +					<&clks IMX7D_QSPI_ROOT_CLK>;
> > +				clock-names = "qspi_en", "qspi";
> > +				status = "disabled";
> > +			};
> > +
> >  			sdma: sdma@30bd0000 {
> >  				compatible = "fsl,imx7d-sdma",
> > "fsl,imx35-sdma";
> >  				reg = <0x30bd0000 0x10000>;
> 
> Regards,
>   Marco